metricbeat: fix zookeeper fetching file descriptor info incorrectly #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
exekias
approved these changes
Dec 18, 2017
|
ok to test |
exekias
added
bug
Metricbeat
…correctly Use `zk_open_file_descriptor_count` instead of `open_file_descriptor_count` to check whether the zookeeper is running on Unix platforms. Because the output variable is `zk_open_file_descriptor_count` depending on the doc [ZooKeeper Administrator's Guide](http://zookeeper.apache.org/doc/current/zookeeperAdmin.html#sc_zkCommands)
wangdisdu
force-pushed
the
metricbeat-zookeeper-mntr
branch
from
0a24112 to
f5bd084
Compare
|
Hi @exekias , i have added a CHANGELOG entry. |
|
jenkins, test it |
ruflin
approved these changes
Dec 19, 2017
|
@wangdisdu Thanks for the fix. |
ruflin
removed
the
needs_backport
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Dec 20, 2017
…correctly (elastic#5902) Use `zk_open_file_descriptor_count` instead of `open_file_descriptor_count` to check whether the zookeeper is running on Unix platforms. Because the output variable is `zk_open_file_descriptor_count` depending on the doc [ZooKeeper Administrator's Guide](http://zookeeper.apache.org/doc/current/zookeeperAdmin.html#sc_zkCommands) (cherry picked from commit 66d4500)
andrewkroh
pushed a commit
that referenced
this pull request
Dec 21, 2017
…correctly (#5902) (#5917) Use `zk_open_file_descriptor_count` instead of `open_file_descriptor_count` to check whether the zookeeper is running on Unix platforms. Because the output variable is `zk_open_file_descriptor_count` depending on the doc [ZooKeeper Administrator's Guide](http://zookeeper.apache.org/doc/current/zookeeperAdmin.html#sc_zkCommands) (cherry picked from commit 66d4500)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…correctly (elastic#5902) (elastic#5917) Use `zk_open_file_descriptor_count` instead of `open_file_descriptor_count` to check whether the zookeeper is running on Unix platforms. Because the output variable is `zk_open_file_descriptor_count` depending on the doc [ZooKeeper Administrator's Guide](http://zookeeper.apache.org/doc/current/zookeeperAdmin.html#sc_zkCommands) (cherry picked from commit 8b253db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
zk_open_file_descriptor_countinstead ofopen_file_descriptor_countto check whether the zookeeper is running on Unix platforms.Because the output variable is
zk_open_file_descriptor_countdepending on the doc ZooKeeper Administrator's Guide