#6066: Extract json deDot feature from metricbeat/http module to libbeat/common #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
houndci-bot
reviewed
Jan 13, 2018
libbeat/common/event.go
Outdated
|
|
||
| // DeDot a json struct by replacing all . with _ | ||
| // This helps when sending data to Elasticsearch to prevent object and key collisions. | ||
| func DeDotJson(json interface{}) interface{} { |
There was a problem hiding this comment.
func DeDotJson should be DeDotJSON
libbeat/common/event.go
Outdated
| @@ -256,3 +256,24 @@ func (f Float) MarshalJSON() ([]byte, error) { | |||
| func DeDot(s string) string { | |||
| return strings.Replace(s, ".", "_", -1) | |||
| } | |||
|
|
|||
| // DeDot a json struct by replacing all . with _ | |||
There was a problem hiding this comment.
comment on exported function DeDotJson should be of the form "DeDotJson ..."
christiangalsterer
changed the title
christiangalsterer
force-pushed
the
i6066
branch
from
9fc860d to
300197f
Compare
|
@ruflin as discussed here the PR for extracting the de dot feature for json into libbeats. |
ruflin
reviewed
Jan 16, 2018
| @@ -3,8 +3,8 @@ | |||
| "key_with_dot_l2": 1, | |||
| "key_with_multiple_dots_l2": 2, | |||
| "key_without_dot_l2": { | |||
| "key_with_dot_l2": 3, | |||
| "key_with_multiple_dots_l2": 4 | |||
| "key_with_dot_l3": 3, | |||
There was a problem hiding this comment.
Let's call the directory testdata which is more idiomatic for Golang. The _meta data directory is specific to our modules where we automatically generate some information, we don't need it here I think.
There was a problem hiding this comment.
Moved the test data to testdata folder
…to libbeat/common - Moved test data to testdata folder
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.