Revert the validation on dotted key in the keystore and add a cyclic reference test case #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
fix/revert-dotted-key-validation
branch
from
82f9d70 to
fcd62d4
Compare
ph
added
needs_backport
|
elastic/go-ucfg#97 was merged, waiting for CI to run everything. |
|
Thanks @exekias! |
…r configuration. (elastic#6077)" This reverts commit 0cdcf4f.
Adding a specific system env test to target a cyclic reference in the configuration.
This update allow us to support top level key reference when the top level doesn't already exist in the YAML document and it allow us to use cyclic reference in a yaml document if the key exist in other resolvers. Ref: elastic/go-ucfg#97
ph
force-pushed
the
fix/revert-dotted-key-validation
branch
from
fcd62d4 to
5a855d8
Compare
|
updated with a fixed version on go-ucfg (0.5.0) instead of a commit hash. |
ph
added a commit
to ph/beats
that referenced
this pull request
Jan 23, 2018
…reference test case (elastic#6098) * Revert "Refuse to store dotted keys to prevent cyclic reference in our configuration. (elastic#6077)" This reverts commit 0cdcf4f. * Keystore adding a system env test Adding a specific system env test to target a cyclic reference in the configuration. * Update go-ucfg This update allow us to support top level key reference when the top level doesn't already exist in the YAML document and it allow us to use cyclic reference in a yaml document if the key exist in other resolvers. Ref: elastic/go-ucfg#97 * Update changelog (cherry picked from commit 34b6a46)
tsg
pushed a commit
that referenced
this pull request
Jan 24, 2018
…reference test case (#6098) (#6154) * Revert "Refuse to store dotted keys to prevent cyclic reference in our configuration. (#6077)" This reverts commit 0cdcf4f. * Keystore adding a system env test Adding a specific system env test to target a cyclic reference in the configuration. * Update go-ucfg This update allow us to support top level key reference when the top level doesn't already exist in the YAML document and it allow us to use cyclic reference in a yaml document if the key exist in other resolvers. Ref: elastic/go-ucfg#97 * Update changelog (cherry picked from commit 34b6a46)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…reference test case (elastic#6098) (elastic#6154) * Revert "Refuse to store dotted keys to prevent cyclic reference in our configuration. (elastic#6077)" This reverts commit f531ac0. * Keystore adding a system env test Adding a specific system env test to target a cyclic reference in the configuration. * Update go-ucfg This update allow us to support top level key reference when the top level doesn't already exist in the YAML document and it allow us to use cyclic reference in a yaml document if the key exist in other resolvers. Ref: elastic/go-ucfg#97 * Update changelog (cherry picked from commit 375191e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are reverting the change in 0cdcf4f and we will allow dotted key in the keystore. We also add a system env test that add a cyclic reference use case.
This PR depends on elastic/go-ucfg#97 allowing configuration to define cyclic references.