Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix float32 normalizeValue panic #6129

Merged
merged 3 commits into from
Jan 23, 2018
Merged

fix float32 normalizeValue panic #6129

merged 3 commits into from
Jan 23, 2018

Conversation

iahmedov
Copy link
Contributor

Closes #6128

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin ruflin added bug Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. labels Jan 21, 2018
@ruflin
Copy link
Contributor

ruflin commented Jan 21, 2018

@iahmedov Thanks for the fix. Could you add a CHANGELOG entry?

@urso Could you have a quick look at this?

@ruflin
Copy link
Contributor

ruflin commented Jan 21, 2018

jenkins, test it

@ruflin ruflin added the review label Jan 21, 2018
ruflin
ruflin approved these changes Jan 21, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins, test it

@urso
Copy link

urso commented Jan 22, 2018

Nice. One. As changelogs are consumer by users, not developers let's rephrase the changelog to fix panic when Events containing a float32 value are normalized.

@ruflin
Copy link
Contributor

ruflin commented Jan 22, 2018

jenkins, test it

@ruflin ruflin merged commit c7ac03a into elastic:master Jan 23, 2018
@ruflin
Copy link
Contributor

ruflin commented Jan 23, 2018

@iahmedov Thanks a lot for the fix.

@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jun 18, 2018
cyrilleverrier pushed a commit to cyrilleverrier/beats that referenced this pull request Feb 1, 2019
@iahmedov @cyrilleverrier
fix float32 normalizeValue panic (elastic#6129)
5a76b43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@urso urso urso approved these changes

Assignees
No one assigned
Labels
bug Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iahmedov @elasticmachine @ruflin @urso