Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbeat: Add a new way to detect node for k8s which using machine-id #6146

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

walktall
Copy link
Contributor

This PR comes from #6117

Focus on node auto detection when beat is deployed outside k8s cluster.

@exekias PTAL~

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing @walktall! Could you please add a changelog entry?

@exekias
Copy link
Contributor

exekias commented Jan 23, 2018

jenkins, test it please

@walktall
Copy link
Contributor Author

@exekias changelog entry added, PTAL.

@exekias exekias merged commit 9930cb7 into elastic:master Jan 23, 2018
@walktall walktall deleted the k8s-node-discovery branch February 4, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants