Update to Golang 1.9.4 #6326

ph · 2018-02-08T18:35:38Z

Keep up with the latest version of Golang.

ph · 2018-02-08T18:35:54Z

waiting for CI before tagging for review.

ph · 2018-02-08T18:52:53Z

Since 1.9.4, go restrict the usage of cgo flags, I wanted to see what is currently breaking.

andrewkroh · 2018-02-08T18:55:04Z

Check .appveyor.yml too.

ph · 2018-02-08T19:04:55Z

@andrewkroh ~~It uses .go-version~~ nevermind I think you are talking about the flags :D

ph · 2018-02-08T19:12:51Z

I am thinking about upgrading the psutil lib, they have removed the custom ldflags, I've also notified the issues concerning the compiled with a newer version

ph · 2018-02-08T19:27:17Z

Some core package aren't updated for this issue, see

./vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:13:3: //go:cgo_import_dynamic libc_pipe pipe "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:14:3: //go:cgo_import_dynamic libc_getsockname getsockname "libsocket.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:15:3: //go:cgo_import_dynamic libc_getcwd getcwd "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:16:3: //go:cgo_import_dynamic libc_getgroups getgroups "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:17:3: //go:cgo_import_dynamic libc_setgroups setgroups "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:18:3: //go:cgo_import_dynamic libc_wait4 wait4 "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:19:3: //go:cgo_import_dynamic libc_gethostname gethostname "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:20:3: //go:cgo_import_dynamic libc_utimes utimes "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:21:3: //go:cgo_import_dynamic libc_utimensat utimensat "libc.so" only allowed in cgo-generated code
../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:22:3: //go:cgo_import_dynamic libc_fcntl fcntl "libc.so" only allowed in cgo-generated code

ph · 2018-02-08T19:31:31Z

Weird psutil should have worked, the flag is in the whitelist.

ruflin · 2018-02-08T23:48:37Z

@ph Seeing that you updated some x packages, this PR is kind of related by @cyrilleverrier #6246

ph · 2018-02-08T23:56:25Z

I have changed strategy,I won’t update them if possible

On Thu, Feb 8, 2018 at 6:48 PM Nicolas Ruflin ***@***.***> wrote: @ph <https://github.com/ph> Seeing that you updated some x packages, this PR is kind of related by @cyrilleverrier <https://github.com/cyrilleverrier> #6246 <#6246> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6326 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAACgN4fRAYQLF7wZdacYzQ_k3Y5XaqUks5tS4fWgaJpZM4R-06X> .

-- ph

kvch · 2018-02-09T18:15:12Z

libbeat/scripts/Makefile

@@ -52,7 +52,7 @@ NOSETESTS_OPTIONS?=--process-timeout=$(TIMEOUT) --with-timer -v --with-xunit --x
 TEST_ENVIRONMENT?=false ## @testing if true, "make testsuite" runs integration tests and system tests in a dockerized test environment
 SYSTEM_TESTS?=false ## @testing if true, "make test" and "make testsuite" run unit tests and system tests
 STRESS_TESTS?=false ## @testing if true, "make test" and "make testsuite" run also run the stress tests
-GOX_OS?=linux darwin windows solaris freebsd netbsd openbsd ## @Building List of all OS to be supported by "make crosscompile".


An "f" is missing from "freebsd".

ruflin · 2018-02-11T22:05:56Z

@ph Should we open an issue to readd solaris as soon as the above issue is fixed?

ruflin · 2018-02-11T22:10:18Z

@ph One more question: You have added the backport label. Not sure what the advantage would be to backport this to 6.2? Brew?

ruflin · 2018-02-11T23:13:31Z

vendor/vendor.json

@@ -1025,6 +1025,14 @@
 			"revision": "5bf94b69c6b68ee1b541973bb8e1144db23a194b",
 			"revisionTime": "2017-03-21T23:07:31Z"
 		},
+		{


I wonder why this is added as I does not seem we use the "top level" gopsutil package anywhere. How did you "update" gopsutil?

Keep up with the latest version of Golang. Version prior to 1.9.4 are affected by security issues on build. `go get` could have been used to do unwanted code execution[1] CVE-2018-6574 during build. The changes in golang now enforce more restrictive pragma declaration when linking and compiling. This commits, disable crosscompiling under solaris which requires an update on the standard library. ``` ../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:13:3: //go:cgo_import_dynamic libc_pipe pipe "libc.so" only allowed in cgo-generated code ../vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:14:3: //go:cgo_import_dynamic libc_getsockname getsockname "libsocket.so" only allowed in cgo-generated code ``` We also update popsutil, thag was incorrectly defining an ldflags in a previous release making the build fails under the new restriction. [1] golang/go#23672

ph · 2018-02-12T16:44:45Z

@ruflin good catch, I've learned today.

@ph One more question: You have added the backport label. Not sure what the advantage would be to backport this to 6.2? Brew?

For two reason:

Its a CVE issues (cmd/go: arbitrary code execution during “go get” golang/go#23672).
Yes, brew is currently blocked because of this metricbeat 6.2.1 Homebrew/homebrew-core#23847, it might be solved by macOS packaging for beats #6344 Not sure, I don't know all the details of the homebrew packaging, but currently it need to be build with their environment.

ph · 2018-02-12T19:17:10Z

@ruflin I've created the issue #6359 for Solaris.

ph · 2018-02-13T20:22:36Z

@ruflin Is there anything missing in this PR?

ph · 2018-02-13T21:10:29Z

Are we fine with with backporting to 6.2? If so before or after 6.2.2?

On Tue, Feb 13, 2018 at 4:08 PM Nicolas Ruflin ***@***.***> wrote: Merged #6326 <#6326>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6326 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAACgDElP0xtooXzmROa20O3y9j8B7K6ks5tUfnBgaJpZM4R-06X> .

-- ph

ph · 2018-02-13T21:50:21Z

Currently we have decided not to backport it to 6.2.

ph added the libbeat label Feb 8, 2018

ph force-pushed the fix/update-golang1.4 branch from 9347930 to 3bfa5da Compare February 8, 2018 18:36

ph added the in progress Pull request is currently in progress. label Feb 8, 2018

tylerjl mentioned this pull request Feb 8, 2018

metricbeat 6.2.1 Homebrew/homebrew-core#23847

Closed

ph force-pushed the fix/update-golang1.4 branch 3 times, most recently from 30de83e to e889e67 Compare February 9, 2018 17:14

ph added review needs_backport PR is waiting to be backported to other branches. and removed in progress Pull request is currently in progress. labels Feb 9, 2018

kvch reviewed Feb 9, 2018

View reviewed changes

ph force-pushed the fix/update-golang1.4 branch from e889e67 to 1cb18f8 Compare February 9, 2018 18:17

ruflin reviewed Feb 11, 2018

View reviewed changes

ph added 2 commits February 12, 2018 11:39

update vendor correctly

00cadd7

ph force-pushed the fix/update-golang1.4 branch from 1cb18f8 to 00cadd7 Compare February 12, 2018 16:39

ph mentioned this pull request Feb 12, 2018

Fix Solaris cross compiling #6359

Closed

ruflin merged commit 9e46667 into elastic:master Feb 13, 2018

ph removed the needs_backport PR is waiting to be backported to other branches. label Feb 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Golang 1.9.4 #6326

Update to Golang 1.9.4 #6326

ph commented Feb 8, 2018

ph commented Feb 8, 2018

ph commented Feb 8, 2018

andrewkroh commented Feb 8, 2018

ph commented Feb 8, 2018 •

edited

Loading

ph commented Feb 8, 2018

ph commented Feb 8, 2018 •

edited

Loading

ph commented Feb 8, 2018

ruflin commented Feb 8, 2018

ph commented Feb 8, 2018 via email •

edited

Loading

kvch Feb 9, 2018

ph Feb 9, 2018

ph Feb 9, 2018

ruflin commented Feb 11, 2018

ruflin commented Feb 11, 2018

ruflin Feb 11, 2018

ph commented Feb 12, 2018

ph commented Feb 12, 2018

ph commented Feb 13, 2018

ph commented Feb 13, 2018 via email

ph commented Feb 13, 2018

Update to Golang 1.9.4 #6326

Update to Golang 1.9.4 #6326

Conversation

ph commented Feb 8, 2018

ph commented Feb 8, 2018

ph commented Feb 8, 2018

andrewkroh commented Feb 8, 2018

ph commented Feb 8, 2018 • edited Loading

ph commented Feb 8, 2018

ph commented Feb 8, 2018 • edited Loading

ph commented Feb 8, 2018

ruflin commented Feb 8, 2018

ph commented Feb 8, 2018 via email • edited Loading

kvch Feb 9, 2018

Choose a reason for hiding this comment

ph Feb 9, 2018

Choose a reason for hiding this comment

ph Feb 9, 2018

Choose a reason for hiding this comment

ruflin commented Feb 11, 2018

ruflin commented Feb 11, 2018

ruflin Feb 11, 2018

Choose a reason for hiding this comment

ph commented Feb 12, 2018

ph commented Feb 12, 2018

ph commented Feb 13, 2018

ph commented Feb 13, 2018 via email

ph commented Feb 13, 2018

ph commented Feb 8, 2018 •

edited

Loading

ph commented Feb 8, 2018 •

edited

Loading

ph commented Feb 8, 2018 via email •

edited

Loading