Add Jolokia agent in proxy mode #6475

whale-shark · 2018-02-26T15:08:20Z

Modified the object of sending to support Jolokia proxy mode.

Correct mapping to mappings

…exist

elasticmachine · 2018-02-26T15:08:22Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

houndci-bot · 2018-02-26T15:08:29Z

metricbeat/module/jolokia/jmx/config.go

+}
+
+type TargetBlock struct {
+	Url      string `json:"url"`


struct field Url should be URL

houndci-bot · 2018-02-26T15:08:29Z

metricbeat/module/jolokia/jmx/config.go

+	Target    *TargetBlock `json:"target,omitempty"`
+}
+
+type TargetBlock struct {


exported type TargetBlock should have comment or be unexported

houndci-bot · 2018-02-26T15:08:29Z

metricbeat/module/jolokia/jmx/config.go

 }

 type Attribute struct {
 	Attr  string
 	Field string
 }

+type Target struct {
+	Url      string


struct field Url should be URL

houndci-bot · 2018-02-26T15:08:29Z

metricbeat/module/jolokia/jmx/config.go

 }

 type Attribute struct {
 	Attr  string
 	Field string
 }

+type Target struct {


exported type Target should have comment or be unexported

ruflin · 2018-02-27T00:51:40Z

@whale-shark Thanks a lot for opening this PR. Could you make Houndci happy and add an entry to the CHANGELOG.asciidoc file? I'm pretty sure this change will make quite a few people happy.

I was wondering if there is a good way to have automated tests for this?

whale-shark · 2018-02-27T15:47:07Z

@ruflin I plan to carry out CI correspondence and document addition on the weekend.

I've just started Go language, and I'm also studying about testing.
Jolokia's test did not work for both make test-module [no test files] and go test jmx_integration_test.go from the beginning.
I also want to do a good test and good automated test.

Absolutely test is necessary?

ruflin · 2018-02-28T08:32:48Z

I wonder if jolokia can be run in proxy mode also if it's run on the same machine? Best would be to have also a docker container with the full setup we then can connect to to test this the same way as we do it now. Perhaps we could even have 2 instances of Jolokia running, one in proxy mode and one not?

The main reason I'm asking for tests is because in case it breaks I'm looking for an easy way to have a setup to also test it manually. And there is obviously the benefit of the automated way of knowing when it breaks.

Please post any questions you have for the setup or beats here, more then happy to help you get going.

ruflin · 2018-03-14T15:35:35Z

@whale-shark Any update here? Would be great to move this forward.

whale-shark · 2018-03-14T15:43:57Z

Sorry for late reply.
I'm busy with my job and I've not been able enough time to create a test.

I am considering adding an instance of docker to connect to remote JMX.

Please wait just a little longer.

whale-shark · 2018-04-23T14:10:03Z

I am sorry to be late.
Unit test and integration test added.

I changed Dockerfile.
In the original configuration, it can not be launched in proxy mode.
So I deployed jolokia's war to Tomcat to work in proxy mode.
Also, we added a new Tomcat to be connected in proxy mode.

ruflin · 2018-04-23T20:10:49Z

@whale-shark Any chance you could rebase this on the most recent version of master?

…atch # Conflicts: # metricbeat/module/jolokia/_meta/Dockerfile # metricbeat/module/jolokia/jmx/_meta/docs.asciidoc # metricbeat/module/jolokia/jmx/data_test.go

whale-shark · 2018-04-25T10:18:38Z

@ruflin I merged with the most recent master.
And I modified it to go through the test.

Would you verification please.

jsoriano · 2018-04-25T15:43:29Z

CHANGELOG.asciidoc

+- Update the MySQL dashboard to use the Time Series Visual Builder. {pull}5996[5996]
+- Add experimental uwsgi module. {pull}6006[6006]
+- Docker and Kubernetes modules are now GA, instead of Beta. {pull}6105[6105]
+- Add Jolokia agent in proxy mode. {pull}6475[6475]


@whale-shark something weird happened with the changelog after updating the branch, could you remove the added lines that are not related with your change?

jsoriano · 2018-04-25T15:45:20Z

jenkins, test this please

…atch

Jolokia agent in proxy mode

whale-shark · 2018-04-26T12:56:40Z

@jsoriano Thank you for pointing out

I revert to latest branch and added my fix line.

jsoriano · 2018-04-26T15:19:02Z

jenkins, test this

jsoriano · 2018-04-26T16:34:15Z

metricbeat/module/jolokia/_meta/Dockerfile

+
+# Set up a server to be connected in proxy mode
+RUN wget http://archive.apache.org/dist/tomcat/tomcat-9/v${PROXT_TARGET_TOMCAT_VERSION}/bin/${PX_TC}.tar.gz;\
+    tar xzf ${PX_TC}.tar.gz -C /usr;\


Can you also remove these .tar.gz files that are not needed in the final image?

I deleted the unnecessary tar.gz file from the final image.

jsoriano · 2018-04-26T16:40:12Z

metricbeat/module/jolokia/_meta/Dockerfile

+    -Dcom.sun.management.jmxremote.ssl=false\
+    -Dcom.sun.management.jmxremote.authenticate=true"\
+    /usr/${PX_TC}/bin/catalina.sh run & \
+    env CATALINA_OPTS="-Dorg.jolokia.jsr160ProxyEnabled" /usr/${TC}/bin/catalina.sh run


Would it be possible to run everything in an only tomcat?

In order to check the connection in Proxy mode, Tomcat to be connected is added.
If you use in an only Tomcat, you will not know if you are connected to another Tomcat in the process of connecting in Proxy mode of the integration test.

Ok, makes sense, maybe we could think in a two container scenario, but I think we can continue as is.

Changed the connecting to another Tomcat to a pattern where jmx password authentication cannot be performed correctly.
Fix to be possible to run everything in an only Tomcat.

…atch

jsoriano · 2018-04-30T11:21:23Z

jenkins, test this please

…atch

jsoriano · 2018-05-04T17:34:01Z

jenkins, test this please

…atch # Conflicts: # metricbeat/module/jolokia/jmx/config.go

whale-shark · 2018-05-11T14:09:18Z

@jsoriano Fixed a file conflicting with the latest source.

jsoriano · 2018-05-14T16:21:34Z

jenkins, test this, please

jsoriano · 2018-05-14T16:50:37Z

jenkins, test this again, please

jsoriano · 2018-05-14T17:33:05Z

Failing tests are not related.

whale-shark added 5 commits January 22, 2018 01:48

Fix typo in jolokia.yml

7dd17a3

Correct mapping to mappings

Fix for Support Jolokia agent in proxy mode (elastic#4421)

3bbaf6c

Fixed an issue that can not be acquired when the target key does not …

a0c68e6

…exist

Fix for Support Jolokia agent in proxy mode (elastic#4421)

e2a13b0

Delete unrelated commit.

a022997

houndci-bot reviewed Feb 26, 2018

View reviewed changes

whale-shark mentioned this pull request Feb 26, 2018

Support Jolokia agent in proxy mode #4421

Closed

ruflin added module review Metricbeat Metricbeat labels Feb 27, 2018

Add unit tests and integration tests

14fceae

whale-shark added 2 commits April 25, 2018 00:13

Merge remote-tracking branch 'remotes/upstream/master' into jolokia-p…

fad49cc

…atch # Conflicts: # metricbeat/module/jolokia/_meta/Dockerfile # metricbeat/module/jolokia/jmx/_meta/docs.asciidoc # metricbeat/module/jolokia/jmx/data_test.go

Fix to pass the test

45a1e54

jsoriano reviewed Apr 25, 2018

View reviewed changes

whale-shark added 3 commits April 26, 2018 21:37

Revert to 7db33f2

0480dbd

Merge remote-tracking branch 'remotes/upstream/master' into jolokia-p…

4da8a0c

…atch

Add CHANGELOG.asciidoc

2a53cd2

Jolokia agent in proxy mode

jsoriano reviewed Apr 26, 2018

View reviewed changes

whale-shark added 2 commits April 28, 2018 00:40

Remove not needed tar.gz file from final image

4b31ec5

Merge remote-tracking branch 'remotes/upstream/master' into jolokia-p…

120817e

…atch

whale-shark added 2 commits May 1, 2018 22:17

Fix to be possible to run everything in an only Tomcat

37c2be9

Merge remote-tracking branch 'remotes/upstream/master' into jolokia-p…

4ddc664

…atch

Merge remote-tracking branch 'remotes/upstream/master' into jolokia-p…

430b178

…atch # Conflicts: # metricbeat/module/jolokia/jmx/config.go

Fix make check error

7912c30

jsoriano merged commit 3a61bcf into elastic:master May 14, 2018

stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018

Metricbeat: Support Jolokia proxy mode (elastic#6475)

0d8b8a1

stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018

Metricbeat: Support Jolokia proxy mode (elastic#6475)

d265a54

jsoriano mentioned this pull request May 6, 2020

JMX module / input #18324

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Jolokia agent in proxy mode #6475

Add Jolokia agent in proxy mode #6475

whale-shark commented Feb 26, 2018

elasticmachine commented Feb 26, 2018

houndci-bot Feb 26, 2018

houndci-bot Feb 26, 2018

houndci-bot Feb 26, 2018

houndci-bot Feb 26, 2018

ruflin commented Feb 27, 2018

whale-shark commented Feb 27, 2018

ruflin commented Feb 28, 2018

ruflin commented Mar 14, 2018

whale-shark commented Mar 14, 2018

whale-shark commented Apr 23, 2018

ruflin commented Apr 23, 2018

whale-shark commented Apr 25, 2018

jsoriano Apr 25, 2018

jsoriano commented Apr 25, 2018

whale-shark commented Apr 26, 2018

jsoriano commented Apr 26, 2018

jsoriano Apr 26, 2018

whale-shark Apr 27, 2018

jsoriano Apr 26, 2018

whale-shark Apr 27, 2018

jsoriano Apr 30, 2018

whale-shark May 1, 2018

jsoriano commented Apr 30, 2018

jsoriano commented May 4, 2018

whale-shark commented May 11, 2018

jsoriano commented May 14, 2018

jsoriano commented May 14, 2018

jsoriano commented May 14, 2018

Add Jolokia agent in proxy mode #6475

Add Jolokia agent in proxy mode #6475

Conversation

whale-shark commented Feb 26, 2018

elasticmachine commented Feb 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruflin commented Feb 27, 2018

whale-shark commented Feb 27, 2018

ruflin commented Feb 28, 2018

ruflin commented Mar 14, 2018

whale-shark commented Mar 14, 2018

whale-shark commented Apr 23, 2018

ruflin commented Apr 23, 2018

whale-shark commented Apr 25, 2018

Choose a reason for hiding this comment

jsoriano commented Apr 25, 2018

whale-shark commented Apr 26, 2018

jsoriano commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsoriano commented Apr 30, 2018

jsoriano commented May 4, 2018

whale-shark commented May 11, 2018

jsoriano commented May 14, 2018

jsoriano commented May 14, 2018

jsoriano commented May 14, 2018