Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: support broken status line #6631

Merged
merged 2 commits into from
Mar 26, 2018
Merged

http: support broken status line #6631

merged 2 commits into from
Mar 26, 2018

Conversation

adriansr
Copy link
Contributor

User reports some HTTP servers may respond with a broken status line that's missing a space between the status code and the optional status phrase. HTTP clients tested already support this behavior. This patch adjusts the http parser so that this deviation from the standard is accepted.

Fixes #6176

User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176
@ruflin
Copy link
Contributor

ruflin commented Mar 23, 2018

Could you add an entry to the CHANGELOG. Failing tests are not related.

Added new feature to packetbeat:
- Support broken status line
@adriansr
Copy link
Contributor Author

@Rufflin done

@adriansr adriansr added the needs_backport PR is waiting to be backported to other branches. label Mar 23, 2018
@ruflin ruflin merged commit d727a45 into elastic:master Mar 26, 2018
adriansr added a commit to adriansr/beats that referenced this pull request Apr 3, 2018
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176
andrewkroh pushed a commit that referenced this pull request Apr 3, 2018
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes #6176
adriansr added a commit to adriansr/beats that referenced this pull request Apr 6, 2018
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176
andrewkroh pushed a commit that referenced this pull request Apr 6, 2018
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes #6176
@adriansr adriansr removed the needs_backport PR is waiting to be backported to other branches. label Jun 15, 2018
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants