Set status as default metricset in Apache module
#6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
jsoriano
requested changes
Mar 27, 2018
| @@ -6,7 +6,7 @@ This file is generated! See scripts/docs_collector.py | |||
| == Apache module | |||
|
|
|||
| This module periodically fetches metrics from https://httpd.apache.org/[Apache | |||
| HTTPD] servers. | |||
| HTTPD] servers. The default metricset is `namespace`. | |||
There was a problem hiding this comment.
copy/paste :-( Fixed.
jsoriano
approved these changes
Mar 27, 2018
andrewkroh
reviewed
Mar 27, 2018
| @@ -1,5 +1,4 @@ | |||
| - module: apache | |||
| metricsets: ["status"] | |||
| period: 10s | |||
|
|
|||
| # Apache hosts | |||
There was a problem hiding this comment.
I think we could drop the "Apache hosts" comment. It really doesn't any new info IMO.
There was a problem hiding this comment.
host comment removed and also period removed.
ruflin
force-pushed
the
apache-default
branch
2 times, most recently
from
f238a4b to
e8076c9
Compare
The metricset config was removed from the short config as there is only 1 metricset anyway. No need for the user to configure this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metricset config was removed from the short config as there is only 1 metricset anyway. No need for the user to configure this.