Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default metricset in zookeeper module #6674

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Set default metricset in zookeeper module #6674

merged 2 commits into from
Mar 28, 2018

Conversation

jsoriano
Copy link
Member

See #6668

@jsoriano jsoriano requested a review from ruflin March 27, 2018 09:11
@ruflin ruflin mentioned this pull request Mar 27, 2018
Closed
32 tasks
@jsoriano jsoriano force-pushed the zookeeper-default-metricset branch 2 times, most recently from 9b63808 to 7583df5 Compare March 27, 2018 09:35
ruflin
ruflin reviewed Mar 27, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment for reference config file and docs on other PR's.

@jsoriano jsoriano force-pushed the zookeeper-default-metricset branch from 7583df5 to 8a1e857 Compare March 27, 2018 17:17
@jsoriano jsoriano force-pushed the zookeeper-default-metricset branch from 8a1e857 to e90cf0b Compare March 27, 2018 17:18
@jsoriano
Copy link
Member Author

Docs and reference config updated

ruflin
ruflin approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.

@ruflin ruflin merged commit ce66abe into elastic:master Mar 28, 2018
@jsoriano jsoriano deleted the zookeeper-default-metricset branch March 28, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
docs Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin