Set default metricsets for system module #6689
Conversation
jsoriano
force-pushed
the
system-default-metricset
branch
from
cc107a5 to
1f4334a
Compare
| @@ -55,6 +47,16 @@ metricbeat.modules: | |||
| period: 15m | |||
| metricsets: | |||
| - uptime | |||
| #- core | |||
There was a problem hiding this comment.
We probably can remove this and the following lines from the config.yml. Or would you keep them in the advertise the others?
There was a problem hiding this comment.
Yes, I though it could be fine to leave them for visibility. I could also leave them in another commented-out module block.
There was a problem hiding this comment.
I have finally added another commented-out module block for these non-default metricsets.
| @@ -106,6 +107,9 @@ metricbeat.modules: | |||
| # to false. | |||
| #process.include_cpu_ticks: false | |||
|
|
|||
| # Raid mount point to monitor | |||
| #raid.mount_point: '/' | |||
There was a problem hiding this comment.
Thanks for completing this.
jsoriano
force-pushed
the
system-default-metricset
branch
2 times, most recently
from
e9f1851 to
98c6cd3
Compare
|
Fixed a typo that broke compilation, and another one in the documentation. |
| @@ -28,3 +23,9 @@ | |||
| period: 15m | |||
| metricsets: | |||
| - uptime | |||
|
|
|||
| # - module: system | |||
There was a problem hiding this comment.
Nit: There is a space after # which we normally don't have except for comments.
| process.include_top_n: | ||
| by_cpu: 5 # include top 5 processes by CPU | ||
| by_memory: 5 # include top 5 processes by memory | ||
|
|
||
| #- module: system |
There was a problem hiding this comment.
Not sure if the indentation is correct if the # is removed here. It should be 2 spaces before the #.
There was a problem hiding this comment.
I think identation is correct, if the # is removed it stays at the same level as other blocks.
jsoriano
force-pushed
the
system-default-metricset
branch
from
98c6cd3 to
f836de7
Compare
| process.include_top_n: | ||
| by_cpu: 5 # include top 5 processes by CPU | ||
| by_memory: 5 # include top 5 processes by memory | ||
|
|
||
| #- module: system |
| #- diskio | ||
| #- socket | ||
| processes: ['.*'] | ||
| # processes: ['.*'] |
There was a problem hiding this comment.
Two thins here:
- It seemed we changed the default here from having
processesfilter enabled to disabled - If it is commented out, the space after the
#should be removed.
I would keep the previous config if possible.
There was a problem hiding this comment.
I commented it out because this value is already the default one, I could remove it as it is already in the reference config.
jsoriano
force-pushed
the
system-default-metricset
branch
from
f836de7 to
dc5bfb9
Compare
See #6668
Set as default metricset the ones that appear in example configuration enabled and don't require further configuration.