Cherry-pick #6224 to 6.2: Fix system process metricset for kernel processes #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
requested changes
Mar 29, 2018
CHANGELOG.asciidoc
Outdated
| - Fix process cgroup memory metrics for memsw, kmem, and kmem_tcp. {issue}6033[6033] | ||
| - Fix kafka OffsetFetch request missing topic and partition parameters. {pull}5880[5880] | ||
| - Change kubernetes.node.cpu.allocatable.cores to float. {pull}6130[6130] | ||
| - Fix system process metricset for kernel processes. {issue}5700[5700] |
There was a problem hiding this comment.
There seems to be lots of unrelated things here.
There was a problem hiding this comment.
Looks like some manual cleanup is required. Will fix.
On Linux, kernel processes don't have an exe on disk so the `/proc/[PID]/exe` symlink is broken. When Metricbeat tries to read the symlink it gets an error and it skips the whole process. This adds a check for ENOENT and ignores the error which allows kernel processes to be reported by Metricbeat. This is the error that it fixes.
2018-01-30T20:31:02.512Z DEBUG [processes] process/process.go:443 Skip process pid=12113: error getting process exe for pid=12113: readlink /proc/12113/exe: no such file or directory
Fixes elastic#5700
(cherry picked from commit 6bde7d8)
andrewkroh
force-pushed
the
backport_6224_6.2
branch
from
1f46043 to
8063a45
Compare
jsoriano
approved these changes
Mar 29, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Cherry-pick elastic#6224 to 6.2: Fix system process metricset for kernel processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #6224 to 6.2 branch. Original message:
On Linux, kernel processes don't have an exe on disk so the
/proc/[PID]/exesymlink is broken. When Metricbeat tries to read the symlink it gets an error and it skips the whole process. This adds a check for ENOENT and ignores the error which allows kernel processes to be reported by Metricbeat. This is the error that it fixes.Fixes #5700