Move Logstash node_stats under node.stats #6714
Conversation
ruflin
commented
Mar 30, 2018
ruflin
commented
- This is the same as for elasticsearch
- Update data.json accordingly
- Update Logstash version to 6.2.3
- Update data.json generator to support namespace setting
| @@ -78,7 +78,6 @@ func StandardizeEvent(ms mb.MetricSet, e mb.Event, modifiers ...mb.EventModifier | |||
| } | |||
|
|
|||
| e.Timestamp = startTime | |||
| e.Namespace = ms.Registration().Namespace | |||
There was a problem hiding this comment.
@andrewkroh Can you check if this change has unintended side effects on the auditbeat side?
There was a problem hiding this comment.
This will affect MetricSets that provide a Namespace at registration time. I think that by adding a conditional this should be safe.
if e.Namespace == "" {
e.Namespace = ms.Registration().Namespace
}
There was a problem hiding this comment.
@andrewkroh Add the if clause and switched node_stats to also use the registry for the namespace as it's constant. I will do the same for node_stats on the ES side.
CHANGELOG.asciidoc
Outdated
| @@ -73,6 +73,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Support apache status pages for versions older than 2.4.16. {pull}6450[6450] | |||
| - Add support for huge pages on Linux. {pull}6436[6436] | |||
| - Refactor docker CPU calculations to be more consistent with `docker stats`. {pull}6608[6608] | |||
| - Update logstash.node_stats metricset to write data under `logstash.docker.stats.*`. {pull}[] | |||
There was a problem hiding this comment.
I think you meant logstash.node.stats.* not logstash.docker.stats.*?
| @@ -1,4 +1,4 @@ | |||
| FROM docker.elastic.co/logstash/logstash:6.0.0 | |||
| FROM docker.elastic.co/logstash/logstash:6.2.3 | |||
There was a problem hiding this comment.
We have to figure out a way to proactively tests on the snapshots release for that.
There was a problem hiding this comment.
Yeah, it is a general thing we have to come up with a solution, meaning testing each module against multiple versions.
ruflin
force-pushed
the
logstash-nodestats
branch
3 times, most recently
from
736cc8d to
543ae9f
Compare
|
Looks like the node_stats test fail. I probably have to adjust some setting, will investigate. |
|
Looks like the failure is due to fields.yml.
|
* This is the same as for elasticsearch * Update data.json accordingly * Update Logstash version to 6.2.3 * Update data.json generator to support namespace setting
ruflin
force-pushed
the
logstash-nodestats
branch
from
543ae9f to
0bf0b4f
Compare
|
@andrewkroh @ph Tests should be fixed now. Ready for an other round. |
