Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default metricsets for rabbitmq module #6743

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 3, 2018

See #6668

Warnings reporting modules as experimental have been changed to beta, so all metricsets are set as default.

@jsoriano jsoriano requested a review from ruflin April 3, 2018 17:23
@ruflin ruflin mentioned this pull request Apr 3, 2018
32 tasks
period: 10s
hosts: ["localhost:15672"]

username: guest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a default username and password? If not we should comment these two out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out, they are indeed not set by default.

@@ -21,12 +22,7 @@ in <<configuration-metricbeat>>. Here is an example configuration:
----
metricbeat.modules:
- module: rabbitmq
metricsets: ["node", "queue", "connection"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just make the other 2 metricsets beta?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Warning messages about metricsets being experimental changed to beta to
match documentation.
@jsoriano jsoriano force-pushed the rabbitmq-default-metricset branch from c0b4596 to 5d9452c Compare April 4, 2018 08:33
@jsoriano jsoriano changed the title Set connection as default metricset of rabbitmq module Set default metricsets for rabbitmq module Apr 4, 2018
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@ruflin ruflin merged commit 726c9dd into elastic:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants