Support log_format combined setting of NGINX access logs
#6858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvch can you add a test case for that change? |
kvch
force-pushed
the
fix/filebeat/fix/nginx-access-combined-log-format
branch
from
aa5fff1 to
2b13f13
Compare
|
sure. |
|
Should be fixed now. Let's see what the CIs have to say. :) |
kvch
force-pushed
the
fix/filebeat/fix/nginx-access-combined-log-format
branch
from
a3b0c78 to
10aec0a
Compare
kvch
force-pushed
the
fix/filebeat/fix/nginx-access-combined-log-format
branch
from
10aec0a to
670ed57
Compare
|
@kvch Changes look good, waiting for Travis and Jenkins to do the CI dance. |
|
@ph The failing test is unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following log line was not parsed successfully:
""had to match the pattern\"%{WORD:nginx.access.method} %{DATA:nginx.access.url} HTTP/%{NUMBER:nginx.access.http_version}\"It failed because those fields had to be there, empty values were not accepted. Also the pattern looks for
HTTP/which was also missing.Now missing fields are allowed in this part of the message.
Closes #6798