-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify default module configurations #6908
Changes from 7 commits
a8f2728
2581f7e
662dbaa
3ab3e17
efc0520
a6ed0f3
13b1f0e
6f1c0d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,7 +210,9 @@ metricbeat.modules: | |
|
||
#------------------------------- Golang Module ------------------------------- | ||
- module: golang | ||
metricsets: ["expvar","heap"] | ||
#metricsets: | ||
# - expvar | ||
# - heap | ||
period: 10s | ||
hosts: ["localhost:6060"] | ||
heap.path: "/debug/vars" | ||
|
@@ -251,7 +253,8 @@ metricbeat.modules: | |
|
||
#-------------------------------- HTTP Module -------------------------------- | ||
- module: http | ||
metricsets: ["json"] | ||
#metricsets: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we in the reference file have the |
||
# - json | ||
period: 10s | ||
hosts: ["localhost:80"] | ||
namespace: "json_namespace" | ||
|
@@ -264,40 +267,45 @@ metricbeat.modules: | |
#dedot.enabled: false | ||
|
||
- module: http | ||
metricsets: ["server"] | ||
#metricsets: | ||
# - server | ||
host: "localhost" | ||
port: "8080" | ||
enabled: false | ||
# paths: | ||
# - path: "/foo" | ||
# namespace: "foo" | ||
# fields: # added to the the response in root. overwrites existing fields | ||
# key: "value" | ||
#paths: | ||
# - path: "/foo" | ||
# namespace: "foo" | ||
# fields: # added to the the response in root. overwrites existing fields | ||
# key: "value" | ||
|
||
#------------------------------- Jolokia Module ------------------------------ | ||
- module: jolokia | ||
metricsets: ["jmx"] | ||
#metricsets: ["jmx"] | ||
period: 10s | ||
hosts: ["localhost"] | ||
namespace: "metrics" | ||
#path: "/jolokia/?ignoreErrors=true&canonicalNaming=false" | ||
jmx.mappings: | ||
- mbean: 'java.lang:type=Runtime' | ||
attributes: | ||
- attr: Uptime | ||
field: uptime | ||
- mbean: 'java.lang:type=Memory' | ||
attributes: | ||
- attr: HeapMemoryUsage | ||
field: memory.heap_usage | ||
- attr: NonHeapMemoryUsage | ||
field: memory.non_heap_usage | ||
#- mbean: 'java.lang:type=Runtime' | ||
# attributes: | ||
# - attr: Uptime | ||
# field: uptime | ||
#- mbean: 'java.lang:type=Memory' | ||
# attributes: | ||
# - attr: HeapMemoryUsage | ||
# field: memory.heap_usage | ||
# - attr: NonHeapMemoryUsage | ||
# field: memory.non_heap_usage | ||
# GC Metrics - this depends on what is available on your JVM | ||
# - mbean: 'java.lang:type=GarbageCollector,name=ConcurrentMarkSweep' | ||
# attributes: | ||
# - attr: CollectionTime | ||
# field: gc.cms_collection_time | ||
# - attr: CollectionCount | ||
# field: gc.cms_collection_count | ||
#- mbean: 'java.lang:type=GarbageCollector,name=ConcurrentMarkSweep' | ||
# attributes: | ||
# - attr: CollectionTime | ||
# field: gc.cms_collection_time | ||
# - attr: CollectionCount | ||
# field: gc.cms_collection_count | ||
|
||
jmx.application: | ||
jmx.instance: | ||
|
||
#-------------------------------- Kafka Module ------------------------------- | ||
- module: kafka | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
- module: aerospike | ||
# metricsets: ["namespace"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be before metricsets directly for consistency. |
||
period: 10s | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember @andrewkroh suggested to remove period. The part I like about it is that it makes the config even shorter. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One option would be to only include the period when it's not the default of 10s. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In general, I would prefer to keep it as it adds visibility to the setting, any user opening the config file for the module will know what that is and how it works really quick. If we remove it they need to go back to the docs. |
||
hosts: ["localhost:3000"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
- module: apache | ||
#metricsets: | ||
# - status | ||
period: 10s | ||
hosts: ["http://127.0.0.1"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,16 @@ | ||
- module: ceph | ||
metricsets: ["cluster_health", "cluster_status", "monitor_health"] | ||
#metricsets: | ||
# - cluster_health | ||
# - cluster_status | ||
# - monitor_health | ||
period: 10s | ||
hosts: ["localhost:5000"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh, seems like we forgot hosts here :-( |
||
|
||
- module: ceph | ||
metricsets: ["cluster_disk", "osd_tree", "pool_disk"] | ||
#metricsets: | ||
# - cluster_disk | ||
# - osd_tree | ||
# - osd_df | ||
# - pool_disk | ||
period: 1m | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a good example I think where having period in makes sense. |
||
hosts: ["localhost:5000"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
- module: couchbase | ||
#metricsets: | ||
# - bucket | ||
# - cluster | ||
# - node | ||
period: 10s | ||
hosts: ["localhost:8091"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,20 @@ | ||
- module: docker | ||
#metricsets: | ||
# - container | ||
# - cpu | ||
# - diskio | ||
# - healthcheck | ||
# - info | ||
# - memory | ||
# - network | ||
period: 10s | ||
hosts: ["unix:///var/run/docker.sock"] | ||
|
||
# Replace dots in labels with `_`. Set to false to keep dots | ||
labels.dedot: true | ||
|
||
# To connect to Docker over TLS you must specify a client and CA certificate. | ||
#ssl: | ||
#certificate_authority: "/etc/pki/root/ca.pem" | ||
#certificate: "/etc/pki/client/cert.pem" | ||
#key: "/etc/pki/client/cert.key" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
- module: dropwizard | ||
#metricsets: | ||
# - collector | ||
period: 10s | ||
hosts: ["localhost:8080"] | ||
metrics_path: /metrics/metrics | ||
namespace: example |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
- module: elasticsearch | ||
#metricsets: | ||
# - node | ||
# - node_stats | ||
period: 10s | ||
hosts: ["localhost:9200"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
- module: etcd | ||
#metricsets: | ||
# - leader | ||
# - self | ||
# - store | ||
period: 10s | ||
hosts: ["localhost:2379"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
- module: graphite | ||
#metricsets: | ||
# - server | ||
#protocol: "udp" | ||
#templates: | ||
# - filter: "test.*.bash.*" # This would match metrics like test.localhost.bash.stats | ||
# namespace: "test" | ||
# template: ".host.shell.metric*" # test.localhost.bash.stats would become metric=stats and tags host=localhost,shell=bash | ||
# delimiter: "_" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
- module: haproxy | ||
#metricsets: | ||
# - info | ||
# - stat | ||
period: 10s | ||
hosts: ["tcp://127.0.0.1:14567"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,27 @@ | ||
- module: jolokia | ||
metricsets: ["jmx"] | ||
#metricsets: ["jmx"] | ||
period: 10s | ||
hosts: ["localhost"] | ||
namespace: "metrics" | ||
#path: "/jolokia/?ignoreErrors=true&canonicalNaming=false" | ||
jmx.mappings: | ||
- mbean: 'java.lang:type=Runtime' | ||
attributes: | ||
- attr: Uptime | ||
field: uptime | ||
- mbean: 'java.lang:type=Memory' | ||
attributes: | ||
- attr: HeapMemoryUsage | ||
field: memory.heap_usage | ||
- attr: NonHeapMemoryUsage | ||
field: memory.non_heap_usage | ||
#- mbean: 'java.lang:type=Runtime' | ||
# attributes: | ||
# - attr: Uptime | ||
# field: uptime | ||
#- mbean: 'java.lang:type=Memory' | ||
# attributes: | ||
# - attr: HeapMemoryUsage | ||
# field: memory.heap_usage | ||
# - attr: NonHeapMemoryUsage | ||
# field: memory.non_heap_usage | ||
# GC Metrics - this depends on what is available on your JVM | ||
# - mbean: 'java.lang:type=GarbageCollector,name=ConcurrentMarkSweep' | ||
# attributes: | ||
# - attr: CollectionTime | ||
# field: gc.cms_collection_time | ||
# - attr: CollectionCount | ||
# field: gc.cms_collection_count | ||
#- mbean: 'java.lang:type=GarbageCollector,name=ConcurrentMarkSweep' | ||
# attributes: | ||
# - attr: CollectionTime | ||
# field: gc.cms_collection_time | ||
# - attr: CollectionCount | ||
# field: gc.cms_collection_count | ||
|
||
jmx.application: | ||
jmx.instance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now but just want to mention that this pretty fragile as we found out other cases.