Elasticsearch index summary metricset #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 23, 2018
| @@ -0,0 +1,75 @@ | |||
| // +build integration | |||
|
|
|||
| package index_summary | |||
There was a problem hiding this comment.
don't use an underscore in package name
| @@ -0,0 +1,78 @@ | |||
| package index_summary | |||
There was a problem hiding this comment.
don't use an underscore in package name
| @@ -0,0 +1,46 @@ | |||
| // +build !integration | |||
|
|
|||
| package index_summary | |||
There was a problem hiding this comment.
don't use an underscore in package name
| @@ -0,0 +1,77 @@ | |||
| package index_summary | |||
There was a problem hiding this comment.
don't use an underscore in package name
ruflin
force-pushed
the
es-index-summary
branch
3 times, most recently
from
48615a5 to
dbedd70
Compare
ruflin
force-pushed
the
es-index-summary
branch
2 times, most recently
from
e4cd2c1 to
0213dc3
Compare
|
jenkins, test this |
ruflin
force-pushed
the
es-index-summary
branch
3 times, most recently
from
f5fa8e4 to
3cdc538
Compare
This was referenced May 8, 2018
ruflin
force-pushed
the
es-index-summary
branch
3 times, most recently
from
65a88dd to
721c268
Compare
ruflin
commented
May 9, 2018
| @@ -141,17 +142,17 @@ func StandardizeEvent(ms mb.MetricSet, e mb.Event, modifiers ...mb.EventModifier | |||
| // WriteEventToDataJSON writes the given event as "pretty" JSON to | |||
| // a ./_meta/data.json file. If the -data CLI flag is unset or false then the | |||
| // method is a no-op. | |||
| func WriteEventToDataJSON(t testing.TB, fullEvent beat.Event, pathPostfix string) { | |||
| func WriteEventToDataJSON(t testing.TB, fullEvent beat.Event, postfixPath string) { | |||
There was a problem hiding this comment.
@jsoriano Does that look like discussed?
exekias
reviewed
May 9, 2018
|
|
||
| // Fetch gathers stats for each index from the _stats API | ||
| func (m *MetricSet) Fetch(r mb.ReporterV2) { | ||
|
|
There was a problem hiding this comment.
Could you please remove this empty line?
| ) | ||
|
|
||
| func eventMapping(r mb.ReporterV2, info elasticsearch.Info, content []byte) { | ||
|
|
There was a problem hiding this comment.
done ;-) One day I will get used to it ...
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.