Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Golang 1.10.1 #6948

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Update to Golang 1.10.1 #6948

merged 1 commit into from
Apr 27, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Apr 25, 2018

No description provided.

@ruflin ruflin added in progress Pull request is currently in progress. :Infra labels Apr 25, 2018
@exekias
Copy link
Contributor

exekias commented Apr 25, 2018

Can you add prepare-tests after python-env here? I think it should fix libcompose vendor issue: https://github.com/elastic/beats/blob/master/libbeat/scripts/Makefile#L118

@adriansr adriansr mentioned this pull request Apr 25, 2018
Merged
@ruflin
Copy link
Contributor Author

ruflin commented Apr 26, 2018

For the generator test failure, the fix happening in #4834 should also help here.

@ruflin ruflin added review and removed in progress Pull request is currently in progress. labels Apr 26, 2018
@adriansr adriansr merged commit c35d571 into elastic:master Apr 27, 2018
@simitt simitt mentioned this pull request Apr 30, 2018
Merged
@ruflin ruflin deleted the go-1.10.1 branch April 30, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Infra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @exekias @adriansr