Cherry-pick #6950 to 6.3: Fix heartbeat races on event updates #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heartbeat has a many components, each adding fields to an existing event. As events are created per 'TaskRun', this is normally fine. But in case the TaskRunner branches of into multiple Sub-tasks, we will see races on shared event structures. This is the case with multiple ports in the http/tcp configuration or the IPAll setting (ping all known IPs of a given domain). Namespaces in an event can be potentially populated via globally shared structures. This can also lead to unwanted updates or races. This fix clones the event structure before continuing event updates, so to remove the chance of races. (cherry picked from commit e92ed3e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Heartbeat has a many components, each adding fields to an existing event. As events are created per 'TaskRun', this is normally fine. But in case the TaskRunner branches of into multiple Sub-tasks, we will see races on shared event structures. This is the case with multiple ports in the http/tcp configuration or the IPAll setting (ping all known IPs of a given domain). Namespaces in an event can be potentially populated via globally shared structures. This can also lead to unwanted updates or races. This fix clones the event structure before continuing event updates, so to remove the chance of races. (cherry picked from commit bc225fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #6950 to 6.3 branch. Original message:
Resolves: #6616
Heartbeat has a many components, each adding fields to an existing
event. As events are created per 'TaskRun', this is normally fine. But
in case the TaskRunner branches of into multiple Sub-tasks, we will see
races on shared event structures. This is the case with multiple ports
in the http/tcp configuration or the IPAll setting (ping all known IPs
of a given domain).
Namespaces in an event can be potentially populated via globally shared
structures. This can also lead to unwanted updates or races.
This fix clones the event structure before continuing event updates, so
to remove the chance of races.
I did run some tests before and after the change, with the race detector enabled. No more race have been found with this change.