Metricbeat: Ensure canonical naming for JMX beans is disabled #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
module
review
Metricbeat
Closed
Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
jsoriano
force-pushed
the
jolokia-mbean-fields-order
branch
from
20fc7bf to
33fbdd8
Compare
|
jenkins, test this again, please |
|
I don't think failing tests are related. |
ruflin
reviewed
May 9, 2018
|
|
||
|
|
||
| class Test(metricbeat.BaseTest): | ||
|
|
||
| COMPOSE_SERVICES = ['jolokia'] | ||
|
|
||
| @parameterized.expand([ | ||
| 'java.lang:name=PS MarkSweep,type=GarbageCollector', |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
May 9, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
ruflin
pushed a commit
that referenced
this pull request
Jun 14, 2018
…#7061) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jun 15, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
ruflin
pushed a commit
that referenced
this pull request
Jun 15, 2018
…#7062) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jun 20, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body. (cherry picked from commit b9dbb1b)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jun 20, 2018
…c#7047) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body. (cherry picked from commit b9dbb1b)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…c#7047) (elastic#7061) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…c#7047) (elastic#7062) Canonical naming for JMX beans in Jolokia is enabled by default, this orders mbean fields, what breaks metricbeat internal mapping. We were already setting these options in the url, but url parameters are ignored in POST requests. This change adds these parameters as part of the body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonical naming for JMX beans in Jolokia is enabled by default, this
orders mbean fields, what breaks metricbeat internal mapping.
We were already setting these options in the url, but url parameters are
ignored in POST requests. This change adds these parameters as part of
the body.