update vagrantfile to use go defined in .go-version
#7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the powershell and unix provision scripts to use the go defined in `.go-version`.
jsoriano
reviewed
May 11, 2018
| @@ -26,18 +26,31 @@ | |||
| # - Folder syncing doesn't work well. Consider copying the files into the box or | |||
| # cloning the project inside the box. | |||
|
|
|||
| GO_VERSION = File.read(File.join(File.dirname(__FILE__), ".go-version")).strip | |||
|
|
|||
| # Provisioning for Windows PowerShell | |||
| $winPsProvision = <<SCRIPT | |||
There was a problem hiding this comment.
Could we move these scripts to their own files?
|
@jsoriano I would prefer not , and keep that file self contained.
On Fri, May 11, 2018 at 5:51 AM Jaime Soriano Pastor < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Vagrantfile
<#7073 (comment)>:
> @@ -26,18 +26,31 @@
# - Folder syncing doesn't work well. Consider copying the files into the box or
# cloning the project inside the box.
+GO_VERSION = File.read(File.join(File.dirname(__FILE__), ".go-version")).strip
+
# Provisioning for Windows PowerShell
$winPsProvision = <<SCRIPT
Could we move these scripts to their own files?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7073 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAACgA3EsdK49SQXBzIYCf6Ag25oL5Ssks5txV89gaJpZM4T60ns>
.
--
ph
|
jsoriano
approved these changes
May 11, 2018
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
Update the powershell and unix provision scripts to use the go defined in `.go-version`.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
Update the powershell and unix provision scripts to use the go defined in `.go-version`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the powershell and unix provision scripts to use the go defined
in
.go-version.