Update kubernetes examples configuration to use inputs #7080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we made the rename of the prospectors to input we overlooked the update of the kubernetes examples files and readme. Ref elastic#6642
ph
added
Filebeat
|
@exekias I am not too familiar with theses files and how to test them, but they were using |
|
@exekias Are theses files tested as part of the CI? I was suspicious because we were referencing a |
|
We test the manifest can be loaded to a mock kubernetes, so it has a valid format, but we don't really do an integration test, which would require running an actual kubernetes cluster (probably?). I'm open to ideas to improve this, it would be nice to have some e2e testing here 😇 |
|
@exekias we will get there eventually :) |
ph
added a commit
to ph/beats
that referenced
this pull request
May 14, 2018
When we made the rename of the prospectors to input we overlooked the update of the kubernetes examples files and readme. Ref elastic#6642 (cherry picked from commit cbc3f0e)
ph
added
v6.3.0
and removed
needs_backport
exekias
pushed a commit
that referenced
this pull request
May 15, 2018
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
When we made the rename of the prospectors to input we overlooked the update of the kubernetes examples files and readme. Ref elastic#6642
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
When we made the rename of the prospectors to input we overlooked the update of the kubernetes examples files and readme. Ref elastic#6642
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#7095) When we made the rename of the prospectors to input we overlooked the update of the kubernetes examples files and readme. Ref elastic#6642 (cherry picked from commit 343bbe4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we made the rename of the prospectors to input we overlooked the update of
the kubernetes examples files and readme.
Ref #6642