Move common RabbitMQ testing code to its own package #7106
Conversation
| DataDir: "../_meta/testdata/", | ||
| } | ||
|
|
||
| func Server(t *testing.T, c ServerConfig) *httptest.Server { |
There was a problem hiding this comment.
exported function Server should have comment or be unexported
| DataDir string | ||
| } | ||
|
|
||
| var DefaultServerConfig = ServerConfig{ |
There was a problem hiding this comment.
exported var DefaultServerConfig should have comment or be unexported
| "testing" | ||
| ) | ||
|
|
||
| type ServerConfig struct { |
There was a problem hiding this comment.
exported type ServerConfig should have comment or be unexported
jsoriano
force-pushed
the
rabbitmq-testing-package
branch
from
eba9e38 to
f5a8070
Compare
jsoriano
force-pushed
the
rabbitmq-testing-package
branch
2 times, most recently
from
5001195 to
b9a2ea9
Compare
| "os" | ||
| ) | ||
|
|
||
| func GetIntegrationConfig() map[string]interface{} { |
There was a problem hiding this comment.
exported function GetIntegrationConfig should have comment or be unexported
| "os" | ||
| ) | ||
|
|
||
| func GetIntegrationConfig() map[string]interface{} { |
There was a problem hiding this comment.
exported function GetIntegrationConfig should have comment or be unexported
jsoriano
force-pushed
the
rabbitmq-testing-package
branch
from
b9a2ea9 to
c3484eb
Compare
|
I have moved all common code for integration tests to the |
| @@ -17,7 +17,8 @@ def get_importable_lines(go_beat_path, import_line): | |||
| imported_lines.append(module_import) | |||
|
|
|||
| module_path = join(path, module) | |||
| metricsets = [m for m in listdir(module_path) if isdir(join(module_path, m)) and m not in ["_meta", "vendor"]] | |||
| ignore = ["_meta", "vendor", "testing"] | |||
| metricsets = [m for m in listdir(module_path) if isdir(join(module_path, m)) and m not in ignore] | |||
There was a problem hiding this comment.
@ruflin @exekias we are going to have to make a decision about where to place the code shared by metricsets of the same module. If we place it as a subdirectory of the module then we have to add an exception here so it is not imported, and then the module has to be named always the same in all modules.
If we want to avoid collisions with testing package maybe we could call this mstest (ms from metricset) or something like this as in principle two metricsets are only going to import this package from its own module.
If we decide to place these packages in other subdirectory we should also decide where to place it, an option could be under _meta, but I don't like it so much. In any case I'd place them inside the module.
Opinions?
(for context, related with discussion here #7059 (comment))
There was a problem hiding this comment.
(Btw, I love that tests have detected this issue in this PR 😄)
There was a problem hiding this comment.
I wonder if under _meta would even work as I remember something golang ignores everything which starts with and underline.
What about mtest instead of mstest as it's the the things which are shared across the module? Reason I prefer mtest or mstest over testing is one the conflict and the other part is that I think the likelyhood of having a conflicting metricset name is lower.
There was a problem hiding this comment.
I think the reason the tests catched this is because we had some issue around it in the past ;-)
There was a problem hiding this comment.
Ok, I'm good with mtest too.
There was a problem hiding this comment.
lets move forward with it and fix it when we break things :-)
|
jenkins, test this again, please |
jsoriano
force-pushed
the
rabbitmq-testing-package
branch
2 times, most recently
from
273d169 to
df75b57
Compare
jsoriano
force-pushed
the
rabbitmq-testing-package
branch
from
df75b57 to
d5f712e
Compare
New testing package provides a RabbitMQ mocked management API that can be used by all tests in the module. Some additional assertions have been added to detect missing testing files.
New testing package provides a RabbitMQ mocked management API that can be used by all tests in the module. Some additional assertions have been added to detect missing testing files.
New testing package provides a RabbitMQ mocked management API that can be used by all tests in the module.
Some additional assertions have been added to detect missing testing files.