Allow to override the ignore_above option for field of the type keyword.
#7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Jun 1, 2018
libbeat/template/processor.go
Outdated
| @@ -150,11 +150,14 @@ func (p *Processor) keyword(f *common.Field) common.MapStr { | |||
| defaultFields = append(defaultFields, fullName) | |||
|
|
|||
| property["type"] = "keyword" | |||
| property["ignore_above"] = 1024 | |||
| if f.IgnoreAbove != "" { | |||
There was a problem hiding this comment.
Could you add a test for this?
ph
force-pushed
the
fix/allow-keyword-fields-to-override-ignore-above
branch
from
3434c4f to
f782753
Compare
keyword. By default all fields of the type keyword were limitted to 1024 characters, this PR keep the default but allow developers to redefine that limit using the `ignore_above` directive in the field.yml.
ph
force-pushed
the
fix/allow-keyword-fields-to-override-ignore-above
branch
from
f782753 to
ce69b9b
Compare
|
@ruflin added tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default all fields of the type keyword were limitted to 1024
characters, this PR keep the default but allow developers to redefine that limit using the
ignore_abovedirective in the field.yml.Ref: elastic/ecs#6