Fix issues when deploying with kubectl apply
#7284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kubernetes.io/cluster-service` is used by addon-manager to identify services that should be managed by it. When these manifests are deployed usign `kubectl apply` the addon-manager will remove them after a while. As the annotation is only useful when deploying as addon, we can safely remove it.
exekias
added
bug
needs_backport
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Jun 12, 2018
`kubernetes.io/cluster-service` is used by addon-manager to identify services that should be managed by it. When these manifests are deployed usign `kubectl apply` the addon-manager will remove them after a while. As the annotation is only useful when deploying as addon, we can safely remove it.
1 task
adriansr
pushed a commit
that referenced
this pull request
Jun 12, 2018
`kubernetes.io/cluster-service` is used by addon-manager to identify services that should be managed by it. When these manifests are deployed usign `kubectl apply` the addon-manager will remove them after a while. As the annotation is only useful when deploying as addon, we can safely remove it.
exekias
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
`kubernetes.io/cluster-service` is used by addon-manager to identify services that should be managed by it. When these manifests are deployed usign `kubectl apply` the addon-manager will remove them after a while. As the annotation is only useful when deploying as addon, we can safely remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes.io/cluster-serviceis used by addon-manager to identifyservices that should be managed by it. When these manifests are deployed
usign
kubectl applythe addon-manager will remove them after a while.As the annotation is only useful when deploying as addon, we can safely
remove it.
Closes #7271