Make beats properly exit #736
Conversation
ruflin
force-pushed
the
no-exit
branch
2 times, most recently
from
c912e2a to
d610f04
Compare
| err := b.Start() | ||
|
|
||
| if err != nil { | ||
| // TODO: detect if logging was already fully setup or not |
There was a problem hiding this comment.
Maybe that should be logic that gets embedded into logp.
There was a problem hiding this comment.
That would actually be nice. So we could use logp.* in all cases and it would decide if it needs fmt.* or not.
There was a problem hiding this comment.
I opened an issue here to solve this later: #746
|
LGTM other than a few minor suggestions. |
|
@andrewkroh Inputs fixed and rebased again. |
| assert True == self.log_contains("Failed to read") | ||
|
|
||
|
|
||
| def test_invalid_config(self): |
There was a problem hiding this comment.
I suggest also a test for the -testconfig option with a valid configuration file.
| // logging not yet initialized, so using fmt.Printf | ||
| fmt.Printf("Loading config file error: %v\n", err) | ||
| os.Exit(1) | ||
| return fmt.Errorf("Loading config file error: %v\n", err) |
There was a problem hiding this comment.
by convention error strings should start with lowercase, as these are often embedded in some other message.
There was a problem hiding this comment.
Interesting. Looks like we don't follow this rule so far in beats.
There was a problem hiding this comment.
I made all error messages lower case as discussed.
Parts of libbeat were exiting the application directly by using os.Exit(). This makes it impossible always clean up the application before cleanup. In addition, a manager which is part of a beat gets also exited in case the beat exits, which is not inteded. * os.Exit() was removed from all places * Additional tests were added to test exit behaviour * Test for version check was added * Add test for -configtest flag * Make error log messages starting lowercase
Parts of libbeat were exiting the application directly by using os.Exit(). This makes it impossible always clean up the application before cleanup. In addition, a manager which is part of a beat gets also exited in case the beat exits, which is not inteded.