Fix a panic when dealing with remaining at the end of a delimiter #7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
fix/panic-on-remaining-offset-data
branch
from
34542ca to
bbfb4c9
Compare
When the last delimiter is not greedy and we have captured all the data for the defined fields in the Tokenizer string we should ignore the remaining of the string.
ph
force-pushed
the
fix/panic-on-remaining-offset-data
branch
from
bbfb4c9 to
7374391
Compare
|
This issue was reported by @vjsamuel |
|
Dissect is not in 6.3 so no need to backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the last delimiter is not greedy, and we have captured all the data
for the defined fields in the Tokenizer string, we should ignore the
remaining of the string.