Ensure metadata updates don't replace existing pod metrics #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
bug
needs_backport
houndci-bot
reviewed
Jul 11, 2018
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_kubernetes_metadata |
There was a problem hiding this comment.
don't use an underscore in package name
exekias
force-pushed
the
fix-metadata-collision
branch
from
414e5e1 to
c1999dc
Compare
ruflin
approved these changes
Jul 12, 2018
|
Probably you need to rebase on master to also fix the generator header error. |
added 2 commits
July 16, 2018 13:37
Before things change, `add_kubernetes_metadata` would replace everything under `kubernetes.pod` when enriching events. This is not what you want, especially if you are using it in conjunction with the Kubernetes module, where you could smash pod metrics when enriching.
exekias
force-pushed
the
fix-metadata-collision
branch
from
046f58a to
e871906
Compare
|
rebased, tests should pass now |
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jul 16, 2018
) * Ensure metadata updates don't replace existing pod metrics Before things change, `add_kubernetes_metadata` would replace everything under `kubernetes.pod` when enriching events. This is not what you want, especially if you are using it in conjunction with the Kubernetes module, where you could smash pod metrics when enriching. * Update CHANGELOG.asciidoc (cherry picked from commit 3297924)
exekias
added
v6.3.2
and removed
needs_backport
adriansr
pushed a commit
that referenced
this pull request
Jul 16, 2018
…ing pod metrics (#7609) Ensure metadata updates don't replace existing pod metrics Before things change, `add_kubernetes_metadata` would replace everything under `kubernetes.pod` when enriching events. This is not what you want, especially if you are using it in conjunction with the Kubernetes module, where you could smash pod metrics when enriching.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…e existing pod metrics (elastic#7609) Ensure metadata updates don't replace existing pod metrics Before things change, `add_kubernetes_metadata` would replace everything under `kubernetes.pod` when enriching events. This is not what you want, especially if you are using it in conjunction with the Kubernetes module, where you could smash pod metrics when enriching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before things change,
add_kubernetes_metadatawould replace everythingunder
kubernetes.podwhen enriching events.This is not what you want, especially if you are using it in conjunction
with the Kubernetes module, where you could smash pod metrics when
enriching.