Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat: Kafka integration tests with 1.1 #7616

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Metricbeat: Kafka integration tests with 1.1 #7616

merged 2 commits into from
Jul 17, 2018

Conversation

jsoriano
Copy link
Member

Add Kafka integration tests with 1.1.

@jsoriano jsoriano force-pushed the metricbeat-kafka-version branch 2 times, most recently from caa8a50 to 5589e15 Compare July 17, 2018 09:43
@jsoriano jsoriano force-pushed the metricbeat-kafka-version branch from 5589e15 to 068f435 Compare July 17, 2018 10:02
@jsoriano jsoriano mentioned this pull request Jul 17, 2018
Closed
@ruflin
Copy link
Contributor

ruflin commented Jul 17, 2018

Looks like the failing tests on CI are related:

0:14:49 --- FAIL: TestTopic (2.28s)
10:14:49 	partition_integration_test.go:122: Send Kafka Event to topic: test-metricbeat-3867498647992878681
10:14:49 	partition_integration_test.go:71: write No advertised broker with address kafka:9092 found
10:14:49 FAIL
10:14:49 coverage: 28.6% of statements

@jsoriano jsoriano mentioned this pull request Jul 17, 2018
Merged
@jsoriano jsoriano force-pushed the metricbeat-kafka-version branch from d9c5066 to e767c6d Compare July 17, 2018 15:38
@jsoriano
Copy link
Member Author

The issue with this test seems related with the changes in the dockerfiles. Advertised address are ips now, but some tests use the kafka hostname. Our logic to find the broker ID wasn't able to match the kafka hostname to advertised ips, I have added a possible fix that tries to match also the resolved hostname if possible.

@ruflin ruflin merged commit 4946202 into elastic:master Jul 17, 2018
ruflin pushed a commit that referenced this pull request Jul 17, 2018
@jsoriano @ruflin
Document tested kafka versions (#7619)
598e1b5 
Fix tested kafka versions in documentation for 6.3.

In master it was fixed with more changes in #7616 and #7608.
@jsoriano jsoriano deleted the metricbeat-kafka-version branch November 7, 2018 17:00
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano @ruflin
Document tested kafka versions (elastic#7619)
1098625 
Fix tested kafka versions in documentation for 6.3.

In master it was fixed with more changes in elastic#7616 and elastic#7608.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Metricbeat Metricbeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin