Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additions to metricbeats memcached-module #7630

Closed
wants to merge 4 commits into from
Closed

additions to metricbeats memcached-module #7630

wants to merge 4 commits into from

Conversation

Hooddominator
Copy link

added metrics to determ free/used bytes of memory of memcached-instance to metricbeats memcached-module

@Hooddominator
Update data.go
342bb76 
added bytes and limit_maxbytes to schema
@Hooddominator
Update data.json
5e231c9 
updated example data
@Hooddominator
Update fields.yml
8f4851b 
updated fields-description
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Hooddominator Hooddominator mentioned this pull request Jul 18, 2018
Closed
@Hooddominator
Update fields.yml
5b59c2b 
fixed empty newlines
@ruflin
Copy link
Contributor

ruflin commented Jul 19, 2018

Thanks for opening a PR with this. Could you run locally make fmt and make update. This should update all the generated files with the changes.

@jsoriano jsoriano self-assigned this Jul 23, 2018
@jsoriano jsoriano mentioned this pull request Jul 25, 2018
Merged
@jsoriano
Copy link
Member

jsoriano commented Jul 25, 2018 •
edited
Loading

@Hooddominator Thanks for this PR, please ping us if you need help to finish it.
As the changes look good, in the meantime I have created a new PR (#7740) with this branch updated with master and with the little missing pieces so we can merge them in any case 🙂

@jsoriano
Copy link
Member

We have finally merged these changes in #7740, thanks for working on this!

@jsoriano jsoriano closed this Jul 26, 2018
@Hooddominator
Copy link
Author

thanks

@jsoriano jsoriano mentioned this pull request Jul 27, 2018
Merged
ruflin pushed a commit that referenced this pull request Jul 30, 2018
@jsoriano @ruflin
Cherry-pick #7740 to 6.x: Metricbeat: Add memcached used bytes metrics (
8078b85 
#7776)

Cherry-pick of PR #7740 to 6.x branch. Original message: 

Continue with #7630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsoriano jsoriano

Labels
Metricbeat Metricbeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hooddominator @elasticmachine @ruflin @jsoriano