Release the Ceph Metricbeat module as GA #7661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruflin
commented
Jul 20, 2018
ruflin
commented
- Add docs
- Fix default config
- Extend reference config
ruflin
commented
Jul 20, 2018
| # - osd_tree | ||
| # - osd_df | ||
| # - pool_disk | ||
| metricsets: |
There was a problem hiding this comment.
I think this was actually a "bug" before as it meant the module is started twice with all default metricsets. Should we backport this fix to 6.3?
* Add docs * Fix default config * Extend reference config
|
Hi there, Sorry to jump on this PR, but we're using Ceph here and it turns out that the ceph-rest-api is deprecated since the Luminous release and has been removed in Mimic (see http://docs.ceph.com/docs/mimic/releases/luminous/) It has been replaced by a ceph-mgr plugin (http://docs.ceph.com/docs/luminous/mgr/restful/#). |
ruflin
added
in progress
|
@herver Thank you for the heads up. Will need to investigate more here. Let's hold off merging this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.