Exclude IOWait time from the CPU total #7691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects the following two metrics: * `system.cpu.total.pct` * `system.cpu.total.norm.pct` Fixes elastic#7627.
tsg
force-pushed
the
exclude_iowait_form_cpu_total
branch
from
12fb1bf to
7653ac5
Compare
ruflin
approved these changes
Jul 24, 2018
libbeat/metric/system/cpu/cpu.go
Outdated
| @@ -116,7 +116,8 @@ func cpuPercentages(s0, s1 *sigar.Cpu, numCPU int) Percentages { | |||
| } | |||
|
|
|||
| calculateTotalPct := func() float64 { | |||
| return common.Round(float64(numCPU)-calculatePct(s0.Idle, s1.Idle), common.DefaultDecimalPlacesCount) | |||
| idle := calculatePct(s0.Idle, s1.Idle) + calculatePct(s0.Wait, s1.Wait) | |||
There was a problem hiding this comment.
Could you add a note to this line to explain why we calculate it like this? Can be later.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the following two metrics:
system.cpu.total.pctsystem.cpu.total.norm.pctFixes #7627.