using PR elastic/gosigar#13 to add process user_id to topbeat #773
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
| @@ -1,7 +1,7 @@ | |||
| package main | |||
|
|
|||
| import ( | |||
| topbeat "github.com/elastic/beats/topbeat/beat" | |||
| topbeat "github.com/dr-toboggan/beats/topbeat/beat" | |||
There was a problem hiding this comment.
That is not a good idea as it would mean our topbeat is built based on your repo :-) Please change it back to elastic.
|
@Dr-Toboggan Ignore my previous comments, I missed your comment on the PR. Lets merge your PR to gosigar first. Afterwards lets update the imports of this PR to point to the elastic repo. |
|
The PR to elastic/gosigar has been merged. Also I implemented Username for linux and OSX. So now you can proceed with updating the vendored copy of gosigar (and switch the imports back to |
|
@Dr-Toboggan Could you rebase this to master and update the gosigar version? Let me know if need help with it, I'd be happy to take over. |
|
I believe I've made the necessary changes and committed them. I struggled a bit with git and how to properly clone/modify the code. Please let me know if I need to change anything. Also, I've signed the CLA, but I'm still seeing the warning re: needing to sign it. |
|
I can confirm the CLA signing, thanks! I'll try merging this one at the CLI via a separate PR. |
|
Merging via #845. Thanks @Dr-Toboggan for contributing! |
I'm using PR elastic/gosigar#13 to add process user_id to topbeat this addresses the following issues: elastic/topbeat/issues/36
#590
we're golang noobs so let us know if there are improvements to make before we're ready to merge.