Add support for HTTP encodings #7915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 8, 2018
packetbeat/protos/http/decode.go
Outdated
| io.Reader | ||
| } | ||
|
|
||
| func (_ closeDecorator) Close() error { |
There was a problem hiding this comment.
receiver name should not be an underscore, omit the name if it is unused
adriansr
force-pushed
the
feature/pb/encoding
branch
3 times, most recently
from
3c0b500 to
755e9dd
Compare
andrewkroh
reviewed
Aug 9, 2018
adriansr
force-pushed
the
feature/pb/encoding
branch
3 times, most recently
from
76bc67b to
046355a
Compare
|
Needs a |
This patch adds support for decoding HTTP bodies based on the `Content-Encoding` and `Transfer-Encoding` headers. Supported decoders are `gzip` and `deflate`. Multiple encoders are supported, for example: ``` Content-Encoding: gzip Transfer-Encoding: chunked ``` Or the rarely used but allowed by the standard: ``` Transfer-Encoding: deflate, gzip ``` The difference between `Transfer-Encoding` and `Content-Encoding` is not relevant to packetbeat, so both are treated the same, with the exception that `chunked` can only appear as the last or only element of `Transfer-Encoding`. To avoid decompression bombs, the value specified in `http.max_message_size` (default 10MB) is honored when decoding. A new configuration option, `decode_body` (default true), has been added to the http protocol, allowing to disable this feature.
adriansr
force-pushed
the
feature/pb/encoding
branch
from
046355a to
d1e686b
Compare
|
Hi @andrewkroh , I updated the PR and added a new configuration option and docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for decoding HTTP bodies based on the
Content-EncodingandTransfer-Encodingheaders. Supported decoders aregzipanddeflate.Multiple encoders are supported, for example:
Or the rarely used but allowed by the standard:
The difference between
Transfer-EncodingandContent-Encodingis not relevant to packetbeat, so both are treated the same, with the exception thatchunkedcan only appear as the last or only element ofTransfer-Encoding.To avoid decompression bombs, the value specified in
http.max_message_size(default 10MB) is honored when decoding.A new configuration option,
decode_body(default true), has been added to the http protocol, allowing to disable this feature.