Fix processor autodiscovery docs for Filebeat #7937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ needs escaping as otherwise asciidoc will show an empty code block.
ruflin
added
docs
Filebeat
dedemorton
approved these changes
Aug 10, 2018
| @@ -75,8 +75,8 @@ arbitrary ordering: | |||
|
|
|||
| ["source","yaml",subs="attributes"] | |||
| ------------------------------------------------------------------------------------- | |||
| co.elastic.logs/processors.1.dissect.tokenizer: "%{key1} %{key2}" | |||
| co.elastic.logs/processors.dissect.tokenizer: "%{key2} %{key1}" | |||
| co.elastic.logs/processors.1.dissect.tokenizer: "%\{key1} %\{key2}" | |||
There was a problem hiding this comment.
Escaping works, but you can avoid the need to escape completely by telling asciidoc to treat the whole code block as text. There aren't any asciidoc attributes in this example, so there is no need to usesubs="attributes".
[source,yaml]
-------------------------------------------------------------------------------------
co.elastic.logs/processors.1.dissect.tokenizer: "%{key1} %{key2}"
co.elastic.logs/processors.dissect.tokenizer: "%{key2} %{key1}"
-------------------------------------------------------------------------------------
|
Incidentally this is another example of missing content due to the problem described in elastic/docs#220. (Commenting to get this PR added to the list of problems arising from asciidoc's "default" behavior.) |
|
@dedemorton Changed accordingly. |
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Aug 17, 2018
{ needs escaping as otherwise asciidoc will show an empty code block.
dedemorton
removed
the
needs_backport
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Aug 30, 2018
{ needs escaping as otherwise asciidoc will show an empty code block.
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Aug 31, 2018
{ needs escaping as otherwise asciidoc will show an empty code block.
dedemorton
added a commit
that referenced
this pull request
Sep 4, 2018
…7937 #7939 #7948 #7949 #7950) (#8188) * Reset modulename attribute at the end of a file (#7888) * Add safeguard related statements for max_backoff setting (#7889) * Add docs about append_fields (#7903) * Add docs about append_fields * Remove experimental tag from setup.template.json.enabled description * Metricbeat: Add compatibility notes where missing (#7939) * Metricbeat: Add compatibility notes where missing, based on integration tests * Added review suggestions * Add missing config options to Logstash section of reference.yml (#7883) Closes #3062 * Fix processor autodiscovery docs for Filebeat (#7937) { needs escaping as otherwise asciidoc will show an empty code block. * Add document for beat export dashboard (#7696) * Add document for beat export dashboard Follow up from #7239 * move to command reference * address review comments * review comments applied * apply review feedback * Replace golang with Go (#7948) I've been told that using "golang" instead of "Go" is considered a faux pas in some circles. :-) I've replaced instances in the external docs, but I did not update the changelog, readmes, or code files. * Minor fixes to attributes in module docs (#7949) * Add recommendation to avoid harvesting symlinks when dealing with file rotation (#7950)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#7903 elastic#7937 elastic#7949) (elastic#7996) * Add document for beat export dashboard (elastic#7696) * Add safeguard related statements for max_backoff setting (elastic#7889) * Add docs about append_fields (elastic#7903) * Fix processor autodiscovery docs for Filebeat (elastic#7937) * Minor fixes to attributes in module docs (elastic#7949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ needs escaping as otherwise asciidoc will show an empty code block.