Add debug check to logp.Logger #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
andrewkroh
reviewed
Aug 14, 2018
libbeat/logp/logger.go
Outdated
| @@ -96,6 +97,11 @@ func (l *Logger) DPanic(args ...interface{}) { | |||
| l.sugar.DPanic(args...) | |||
| } | |||
|
|
|||
| // IsDebug checks to see if the given logger is Debug enabled. | |||
| func (l *Logger) IsDebug() bool { | |||
| return l.sugar.Desugar().Check(zapcore.DebugLevel, "") != nil | |||
There was a problem hiding this comment.
We should probably store the original zap.Logger inside of logp.Logger. Originally it held both, but I dropped it because it was never used.
There was a problem hiding this comment.
@andrewkroh, i have made the necessary change
|
jenkins test this |
|
jenkins, test this |
ruflin
approved these changes
Aug 15, 2018
|
jenkins, test this |
andrewkroh
added
the
needs_backport
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Dec 18, 2018
This PR adds a debug check I made sure to check if `Desugar()` is expensive or not. The API is documented as follows: ``` // Desugar unwraps a SugaredLogger, exposing the original Logger. Desugaring // is quite inexpensive, so it's reasonable for a single application to use // both Loggers and SugaredLoggers, converting between them on the boundaries // of performance-sensitive code. ``` (cherry picked from commit 5b54084)
andrewkroh
added
v6.6.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
Dec 18, 2018
This PR adds a debug check I made sure to check if `Desugar()` is expensive or not. The API is documented as follows: ``` // Desugar unwraps a SugaredLogger, exposing the original Logger. Desugaring // is quite inexpensive, so it's reasonable for a single application to use // both Loggers and SugaredLoggers, converting between them on the boundaries // of performance-sensitive code. ``` (cherry picked from commit 5b54084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a debug check
I made sure to check if
Desugar()is expensive or not. The API is documented as follows: