count 429s in elasticsearch output #8056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open to suggestions on how to test this. |
graphaelli
force-pushed
the
count-429
branch
2 times, most recently
from
2f73a5c to
f8dad25
Compare
|
@graphaelli I am +1 to track 429 at the output level, Concerning testing sadly I don't think we test any of the stats at the client level. I would probably take the following strategy:
|
|
I think it would be super helpful to have these values also in stack monitoring. If you agree, could you open a meta issue here? https://github.com/elastic/stack-monitoring |
ph
approved these changes
Aug 27, 2018
| stats.nonIndexable++ | ||
| continue | ||
| if status < 500 { | ||
| if status == http.StatusTooManyRequests { |
There was a problem hiding this comment.
glad I am not the only one that use these constants :)
ruflin
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a libbeat user, I'd like more help tracking down when elasticsearch is the bottleneck in event ingestion and could use configuration tuning or more nodes. A rise in 429s can provide some indication of this situation.
This change adds a new observable method
ErrTooManyand corresponding monitoring metricoutput.events.toomanythat is only reported by the elasticsearch output.Eventually, a distribution of time spent in queue (ack time - receive time) would be useful across more outputs, but this is a start.