Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #8216 to 6.x: Add a wait baseline when looking up registry values #8239

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Sep 5, 2018

Cherry-pick of PR #8216 to 6.x branch. Original message:

With the nature of VMs and disk, writing or reading a file can be out of sync.
Instead of only sleeping only the windows case we sleep on every tested
platform before asserting the content of the registry.

closes #8102

Notes: I am not a fan of adding sleeps call to existing code, but we are in the processing of writing a new registry. The new system offer better way to look for changes in the form of an oplog. So we could refactor the test to check for opload changes instead of the active registry.

With the nature of VMs and disk, writing or reading a file can be out of sync.
Instead of only sleeping only the windows case we sleep on every tested
platform before asserting the content of the registry.

closes elastic#8102

(cherry picked from commit ca78d74)
@ph ph merged commit 191d08c into elastic:6.x Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants