Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone any cached data from docker and k8s #8240

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Sep 5, 2018

Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.
@ph ph force-pushed the fix/clone-any-value-from-cache-in-docker-k8s branch from c2fb425 to 220112d Compare September 5, 2018 13:12
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Sep 5, 2018
@ph
Copy link
Contributor Author

ph commented Sep 5, 2018

We will need to backport for 6.x and 6.4/6.3?

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this one @ph!

@exekias
Copy link
Contributor

exekias commented Sep 5, 2018

I would say yes, although I haven't seen any occurrence of this issue

@ph ph merged commit 65e2e5e into elastic:master Sep 5, 2018
@ph ph deleted the fix/clone-any-value-from-cache-in-docker-k8s branch September 5, 2018 17:03
ph added a commit to ph/beats that referenced this pull request Sep 5, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
@ph ph added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 5, 2018
ph added a commit to ph/beats that referenced this pull request Sep 5, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
@ph ph added the v6.3.3 label Sep 5, 2018
ph added a commit to ph/beats that referenced this pull request Sep 5, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
@ph ph added the v6.4.1 label Sep 5, 2018
ph added a commit that referenced this pull request Sep 6, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
ph added a commit that referenced this pull request Sep 6, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
ph added a commit that referenced this pull request Sep 6, 2018
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit 65e2e5e)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit b4a69c1)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Using cached data can lead to race condition if we have some reference
in place, this commit force a clone on the retrieved data so each event
has his own copy.

(cherry picked from commit b4a69c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants