-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back missing process command-line fields #8258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields `cmdline` and `client_cmdline`, that were recently added to packetbeat, were missing as the feature was merged in parallel to a refactor of the fields generation.
andrewkroh
reviewed
Sep 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This should probably have a changelog. And IIUC we should backport to 6.x and 6.4?
adriansr
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Sep 6, 2018
andrewkroh
reviewed
Sep 6, 2018
CHANGELOG.asciidoc
Outdated
@@ -79,6 +79,7 @@ https://github.com/elastic/beats/compare/v6.4.0...master[Check the HEAD diff] | |||
|
|||
- Fixed a seccomp related error where the `fcntl64` syscall was not permitted | |||
on 32-bit Linux and the sniffer failed to start. {issue}7839[7839] | |||
- Added missing `cmdline` and `client_cmdline` fields to index template. {issue}8258[8258] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/issue/pull/
andrewkroh
approved these changes
Sep 7, 2018
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Sep 7, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to packetbeat, were missing as the feature was merged in parallel to a refactor of the fields generation. (cherry picked from commit a84e51a)
adriansr
added
v6.5.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Sep 7, 2018
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Sep 7, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to packetbeat, were missing as the feature was merged in parallel to a refactor of the fields generation. (cherry picked from commit a84e51a)
adriansr
added a commit
that referenced
this pull request
Sep 10, 2018
adriansr
added a commit
that referenced
this pull request
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields
cmdline
andclient_cmdline
, that were recently added to packetbeat, were missing as the feature was merged in parallel to a refactor of the fields generation.