Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing process command-line fields #8258

Merged
merged 3 commits into from
Sep 7, 2018

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Sep 6, 2018

The fields cmdline and client_cmdline, that were recently added to packetbeat, were missing as the feature was merged in parallel to a refactor of the fields generation.

The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This should probably have a changelog. And IIUC we should backport to 6.x and 6.4?

@adriansr adriansr added the needs_backport PR is waiting to be backported to other branches. label Sep 6, 2018
@@ -79,6 +79,7 @@ https://github.com/elastic/beats/compare/v6.4.0...master[Check the HEAD diff]

- Fixed a seccomp related error where the `fcntl64` syscall was not permitted
on 32-bit Linux and the sniffer failed to start. {issue}7839[7839]
- Added missing `cmdline` and `client_cmdline` fields to index template. {issue}8258[8258]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/issue/pull/

@adriansr adriansr merged commit a84e51a into elastic:master Sep 7, 2018
adriansr added a commit to adriansr/beats that referenced this pull request Sep 7, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.

(cherry picked from commit a84e51a)
@adriansr adriansr added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 7, 2018
adriansr added a commit to adriansr/beats that referenced this pull request Sep 7, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.

(cherry picked from commit a84e51a)
@adriansr adriansr added the v6.4.1 label Sep 7, 2018
adriansr added a commit that referenced this pull request Sep 10, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.

(cherry picked from commit a84e51a)
adriansr added a commit that referenced this pull request Sep 10, 2018
The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.

(cherry picked from commit a84e51a)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…8262)

The fields `cmdline` and `client_cmdline`, that were recently added to
packetbeat, were missing as the feature was merged in parallel to a
refactor of the fields generation.

(cherry picked from commit 3ca78e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants