Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding elasticsearch/ccr metricset #8335

Merged
merged 9 commits into from
Sep 19, 2018
Merged

Adding elasticsearch/ccr metricset #8335

merged 9 commits into from
Sep 19, 2018

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Sep 17, 2018 •
edited
Loading

This PR adds the elasticsearch/ccr metricset which collects cross-cluster replication (CCR) stats from the GET _ccr/stats Elasticsearch API and indexes them in metricbeat-*.

@ycombinator ycombinator added enhancement Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. v7.0.0-alpha1 v6.5.0 labels Sep 17, 2018
@ycombinator ycombinator mentioned this pull request Sep 17, 2018
Merged
@ruflin ruflin mentioned this pull request Sep 17, 2018
Closed
39 tasks
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator force-pushed the metricbeat-elasticsearch-ccr branch from bbb68a9 to 497b915 Compare September 18, 2018 10:10
@chrisronline
Copy link
Contributor

Do you have testing instructions available for this? I'm assuming you just need me to verify the collection has parity against the original?

@ycombinator
Copy link
Contributor Author

@chrisronline Yes, look for parity, same as before. I added concrete test instructions to the PR description.

@ycombinator ycombinator force-pushed the metricbeat-elasticsearch-ccr branch from 497b915 to 99826cc Compare September 18, 2018 14:58
@ycombinator ycombinator requested review from jsoriano and removed request for chrisronline September 18, 2018 17:20
sayden
sayden approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 0f2b29a into elastic:master Sep 19, 2018
@ycombinator ycombinator mentioned this pull request Sep 19, 2018
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Sep 19, 2018
ycombinator added a commit that referenced this pull request Sep 24, 2018
@ycombinator
Cherry-pick #8335 to 6.x: Adding elasticsearch/ccr metricset (#8357)
4f14d66 
* Adding elasticsearch/ccr metricset (#8335)

This PR adds the `elasticsearch/ccr` metricset which collects cross-cluster replication (CCR) stats from the `GET _ccr/stats` Elasticsearch API and indexes them in `metricbeat-*`.

(cherry picked from commit 0f2b29a)

* Cleaning up CHANGELOG
@ycombinator ycombinator deleted the metricbeat-elasticsearch-ccr branch December 25, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees
No one assigned
Labels
enhancement Metricbeat Metricbeat v6.5.0 v7.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @chrisronline @jsoriano @sayden