Correctly parse rfc3339 timezone and Nanosecond #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
review
Filebeat
vjsamuel
reviewed
Sep 18, 2018
vjsamuel
approved these changes
Sep 18, 2018
|
Failures are valid looking into them. |
|
After running a few times, sometime I have the issue and sometime I don't. |
kvch
approved these changes
Sep 20, 2018
The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser.
ph
force-pushed
the
fix/correctly-parses-rfc3339-and-nanosecond
branch
from
790a040 to
87bece8
Compare
|
rebased wating for the ci bots. |
ph
added a commit
to ph/beats
that referenced
this pull request
Sep 25, 2018
* Correctly parse rfc3339 timezone and Nanosecond The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser. (cherry picked from commit 6204fce)
ph
added
v7.0.0
and removed
needs_backport
ph
added a commit
to ph/beats
that referenced
this pull request
Sep 25, 2018
* Correctly parse rfc3339 timezone and Nanosecond The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser. (cherry picked from commit 6204fce)
ph
added a commit
that referenced
this pull request
Sep 25, 2018
…cond (#8432) Cherry-pick of PR #8346 to 6.4 branch. Original message: The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser. bug was reported by @vjsamuel
ph
added a commit
that referenced
this pull request
Sep 25, 2018
…cond (#8433) Cherry-pick of PR #8346 to 6.x branch. Original message: The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser. bug was reported by @vjsamuel
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… Nanosecond (elastic#8432) Cherry-pick of PR elastic#8346 to 6.4 branch. Original message: The code was not correctly creating the time and was isntead making events appear to be a few years in the future. The nanosecond extraction was not on the right scale for the time.Date, the commit fixes the behavior and do assertions with the go parser. bug was reported by @vjsamuel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was not correctly creating the time and was isntead making
events appear to be a few years in the future. The nanosecond extraction
was not on the right scale for the time.Date, the commit fixes the
behavior and do assertions with the go parser.
bug was reported by @vjsamuel