Cherry-pick #8385 to 6.x: Fix dropwizard parsing of metric names #8420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
force-pushed
the
backport_6385_6.x
branch
from
94141ab to
0318542
Compare
adriansr
changed the title
adriansr
force-pushed
the
backport_6385_6.x
branch
from
0318542 to
3174dc9
Compare
Dropwizard metrics parser extracts tags embedded into metrics names. However, it crashes when the metric name contains curly braces. This patch improves parsing by adding additional checks and also makes sures that only tags at the end of the metric name are extracted. Assuming that the tags extracted by the dropwizard module are the ones introduced by this PR: dropwizard/metrics#839 Fixes elastic#8365 (cherry picked from commit f5890b7)
adriansr
force-pushed
the
backport_6385_6.x
branch
from
3174dc9 to
0b6b96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8385 to 6.x branch. Original message:
Dropwizard metrics parser extracts tags embedded into metrics names. However, it crashes when the metric name contains curly braces.
This patch improves parsing by adding additional checks and also makes sures that only tags at the end of the metric name are extracted.
Assuming that the tags extracted by the dropwizard module are the ones introduced by this PR: dropwizard/metrics#839
Fixes #8365