-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat HAproxy Default log format added #8428
Closed
sayden
wants to merge
5
commits into
elastic:master
from
sayden:feature/haproxy-filebeat-default-log-format
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4228d65
Default format added
sayden 93e18f8
Use of a non local ip to trigger the geo_ip plugin
sayden 7375ff5
Remove message field from expected JSON in default format
sayden a27caff
Removed local IP and message from expected JSON of the default format
sayden fd9e9d2
Fields and expected json updated
sayden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,69 @@ | ||
| { | ||
| "description": "Pipeline for parsing HAProxy http logs in their default format. Requires the geoip plugin.", | ||
| "processors": [{ | ||
| "grok": { | ||
| "field": "message", | ||
| "patterns": [ | ||
| "(%{NOTSPACE:haproxy.process_name}\\[%{NUMBER:haproxy.pid:int}\\]: )?%{IP:haproxy.client_ip}:%{NUMBER:haproxy.client_port:int} \\[%{NOTSPACE:haproxy.http.request_date}\\] %{NOTSPACE:haproxy.frontend_name} %{NOTSPACE:haproxy.backend_name}/%{NOTSPACE:haproxy.server_name} %{NUMBER:haproxy.time_client_req:int}/%{NUMBER:haproxy.time_queue:int}/%{NUMBER:haproxy.time_backend_connect:int}/%{NUMBER:haproxy.time_server_response:int}/%{NUMBER:haproxy.time_duration:int} %{NUMBER:haproxy.http.response.status_code:int} %{NUMBER:haproxy.http.response.bytes_read:int} %{NOTSPACE:haproxy.http.request.captured_cookie} %{NOTSPACE:haproxy.http.response.captured_cookie} %{NOTSPACE:haproxy.termination_state} %{NUMBER:haproxy.connections.active:int}/%{NUMBER:haproxy.connections.frontend:int}/%{NUMBER:haproxy.connections.backend:int}/%{NUMBER:haproxy.connections.server:int}/%{NUMBER:haproxy.connections.retries:int} %{NUMBER:haproxy.server_queue:int}/%{NUMBER:haproxy.backend_queue:int} \\{%{DATA:haproxy.http.request.captured_headers}\\} \\{%{DATA:haproxy.http.response.captured_headers}\\} \"%{GREEDYDATA:haproxy.http.request.raw_request_line}\"", | ||
| "(%{NOTSPACE:haproxy.process_name}\\[%{NUMBER:haproxy.pid:int}\\]: )?%{IP:haproxy.client_ip}:%{NUMBER:haproxy.client_port:int} \\[%{NOTSPACE:haproxy.http.request_date}\\] %{NOTSPACE:haproxy.frontend_name}/%{NOTSPACE:haproxy.bind_name} %{GREEDYDATA:haproxy.error_message}" | ||
| ], | ||
| "ignore_missing": false | ||
| } | ||
| }, | ||
| { | ||
| "date": { | ||
| "field": "haproxy.http.request_date", | ||
| "target_field": "@timestamp", | ||
| "formats": ["dd/MMM/yyyy:HH:mm:ss.SSS"] | ||
| } | ||
| }, | ||
| { | ||
| "remove": { | ||
| "field": "haproxy.http.request_date" | ||
| } | ||
| }, | ||
| { | ||
| "geoip": { | ||
| "field": "haproxy.client_ip", | ||
| "target_field": "haproxy.geoip" | ||
| } | ||
| }, | ||
| { | ||
| "split": { | ||
| "field": "haproxy.http.request.captured_headers", | ||
| "separator": "\\|", | ||
| "ignore_failure": true | ||
| } | ||
| }, | ||
| { | ||
| "split": { | ||
| "field": "haproxy.http.response.captured_headers", | ||
| "separator": "\\|", | ||
| "ignore_failure": true | ||
| } | ||
| } | ||
| ], | ||
| "on_failure" : [{ | ||
| "set" : { | ||
| "field" : "error.message", | ||
| "value" : "{{ _ingest.on_failure_message }}" | ||
| } | ||
| }] | ||
| } | ||
| "description": "Pipeline for parsing HAProxy http logs in their default format. Requires the geoip plugin.", | ||
| "processors": [ | ||
| { | ||
| "grok": { | ||
| "field": "message", | ||
| "patterns": [ | ||
| "%{HAPROXY_DATE:haproxy.request_date} (?:%{\\<%{NONNEGINT:haproxy.default.facility}.%{NONNEGINT:haproxy.default.priority}\\>} )?%{IPORHOST:haproxy.default.logsource} %{PROG:haproxy.process_name}(?:\\[%{POSINT:haproxy.pid}\\])?: %{GREEDYDATA} %{IPORHOST:haproxy.client_ip}:%{POSINT:haproxy.client_port} %{WORD} %{IPORHOST:haproxy.destination_ip}:%{POSINT:haproxy.destination_port} \\(%{WORD:haproxy.frontend_name}/%{WORD:haproxy.default.mode}\\)", | ||
|
|
||
| "(%{NOTSPACE:haproxy.process_name}\\[%{NUMBER:haproxy.pid:int}\\]: )?%{IP:haproxy.client_ip}:%{NUMBER:haproxy.client_port:int} \\[%{NOTSPACE:haproxy.request_date}\\] %{NOTSPACE:haproxy.frontend_name} %{NOTSPACE:haproxy.backend_name}/%{NOTSPACE:haproxy.server_name} %{NUMBER:haproxy.time_client_req:int}/%{NUMBER:haproxy.time_queue:int}/%{NUMBER:haproxy.time_backend_connect:int}/%{NUMBER:haproxy.time_server_response:int}/%{NUMBER:haproxy.time_duration:int} %{NUMBER:haproxy.http.response.status_code:int} %{NUMBER:haproxy.http.response.bytes_read:int} %{NOTSPACE:haproxy.http.request.captured_cookie} %{NOTSPACE:haproxy.http.response.captured_cookie} %{NOTSPACE:haproxy.termination_state} %{NUMBER:haproxy.connections.active:int}/%{NUMBER:haproxy.connections.frontend:int}/%{NUMBER:haproxy.connections.backend:int}/%{NUMBER:haproxy.connections.server:int}/%{NUMBER:haproxy.connections.retries:int} %{NUMBER:haproxy.server_queue:int}/%{NUMBER:haproxy.backend_queue:int} \\{%{DATA:haproxy.http.request.captured_headers}\\} \\{%{DATA:haproxy.http.response.captured_headers}\\} \"%{GREEDYDATA:haproxy.http.request.raw_request_line}\"", | ||
|
|
||
| "(%{NOTSPACE:haproxy.process_name}\\[%{NUMBER:haproxy.pid:int}\\]: )?%{IP:haproxy.client_ip}:%{NUMBER:haproxy.client_port:int} \\[%{NOTSPACE:haproxy.request_date}\\] %{NOTSPACE:haproxy.frontend_name}/%{NOTSPACE:haproxy.bind_name} %{GREEDYDATA:haproxy.error_message}" | ||
| ], | ||
| "ignore_missing": false, | ||
| "pattern_definitions": { | ||
| "HAPROXY_DATE": "(%{MONTHDAY}[/-]%{MONTH}[/-]%{YEAR}:%{HOUR}:%{MINUTE}:%{SECOND})|%{SYSLOGTIMESTAMP}" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "date": { | ||
| "field": "haproxy.request_date", | ||
| "target_field": "@timestamp", | ||
| "formats": [ | ||
| "dd/MMM/yyyy:HH:mm:ss.SSS", | ||
| "MMM dd HH:mm:ss" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "remove": { | ||
| "field": "haproxy.request_date" | ||
| } | ||
| }, | ||
| { | ||
| "remove": { | ||
| "field": "message" | ||
| } | ||
| }, | ||
| { | ||
| "geoip": { | ||
| "field": "haproxy.client_ip", | ||
| "target_field": "haproxy.geoip" | ||
| } | ||
| }, | ||
| { | ||
| "split": { | ||
| "field": "haproxy.http.request.captured_headers", | ||
| "separator": "\\|", | ||
| "ignore_failure": true | ||
| } | ||
| }, | ||
| { | ||
| "split": { | ||
| "field": "haproxy.http.response.captured_headers", | ||
| "separator": "\\|", | ||
| "ignore_failure": true | ||
| } | ||
| } | ||
| ], | ||
| "on_failure": [ | ||
| { | ||
| "set": { | ||
| "field": "error.message", | ||
| "value": "{{ _ingest.on_failure_message }}" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Sep 20 15:42:59 1.2.3.4 haproxy[24551]: Connect from 1.2.3.4:40780 to 1.2.3.4:5000 (main/HTTP) |
25 changes: 25 additions & 0 deletions
25
filebeat/module/haproxy/log/test/default.log-expected.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| [ | ||
| { | ||
| "@timestamp": "2018-09-20T15:42:59.000Z", | ||
| "fileset.module": "haproxy", | ||
| "fileset.name": "log", | ||
| "haproxy.client_ip": "1.2.3.4", | ||
| "haproxy.client_port": "40780", | ||
| "haproxy.default.logsource": "1.2.3.4", | ||
| "haproxy.default.mode": "HTTP", | ||
| "haproxy.destination_ip": "1.2.3.4", | ||
| "haproxy.destination_port": "5000", | ||
| "haproxy.frontend_name": "main", | ||
| "haproxy.geoip.city_name": "Mukilteo", | ||
| "haproxy.geoip.continent_name": "North America", | ||
| "haproxy.geoip.country_iso_code": "US", | ||
| "haproxy.geoip.location.lat": 47.913, | ||
| "haproxy.geoip.location.lon": -122.3042, | ||
| "haproxy.geoip.region_name": "Washington", | ||
| "haproxy.pid": "24551", | ||
| "haproxy.process_name": "haproxy", | ||
| "input.type": "log", | ||
| "offset": 0, | ||
| "prospector.type": "log" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't namespace fields depending on the matching pattern, some fields can be common between them, like probably
frontend_name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TCP format PR is also open and waiting and I think I did a better naming there. Let's move on to finish and close this two and then I'll quickly open a new one to write proper naming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After opening a new PR with both PRs, what prevents us on using a proper naming? I'd do it before merging.