Correctly report double licensed project and allow to skip file #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
commented
Sep 25, 2018
| License type (autodetected): MIT | ||
| ./vendor/gopkg.in/yaml.v2/LICENSE.libyaml: | ||
| License type (autodetected): Apache-2.0 | ||
| ./vendor/gopkg.in/yaml.v2/LICENSE: |
There was a problem hiding this comment.
NOTE: This is a dual license project.
When a project had two licenses, the script was creating two entries in the NOTICE.txt but both entries would share the same license. This commit also add the possibility to skip file that start with LICENSE but doesn't contains any license information. It also add MIT-0 license wording see https://github.com/aws/mit-0
ph
force-pushed
the
fix/double-license
branch
from
31139ca to
7828474
Compare
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 1, 2018
…tic#8443) When a project had two licenses, the script was creating two entries in the NOTICE.txt but both entries would share the same license. This commit also add the possibility to skip file that start with LICENSE but doesn't contains any license information. It also add MIT-0 license wording see https://github.com/aws/mit-0 (cherry picked from commit 447e23b)
ph
added
v6.5.0
and removed
needs_backport
Merged
ph
added a commit
that referenced
this pull request
Oct 4, 2018
… (#8516) When a project had two licenses, the script was creating two entries in the NOTICE.txt but both entries would share the same license. This commit also add the possibility to skip file that start with LICENSE but doesn't contains any license information. It also add MIT-0 license wording see https://github.com/aws/mit-0 (cherry picked from commit 447e23b)
ph
added a commit
that referenced
this pull request
Oct 24, 2018
Cherry-pick of PR #8485 to 6.x branch. Original message: ## This PR provide the following 1. Plugin infra for developing providers and functions 2. A local stdin provider only used for testing, I will remove it in the final version. 3. AWS provider and function types for: - Cloudwatch logs - SQS - Kinesis - Api web gateway proxy 4. License checker 5. Packaging of artifact 6. Runners 7. CLI infrastructure 8. CLI to push a cloudwatch logs function. 9. CLI to delete any function 10. Processors support. 11. Types to validate value from the users and the lambda function. ## What it doesn't provides - ECS and full event extraction. (NOT for v1) - Specifying the AWS credentials in the configuration - CLI for SQS, Kinesis, API - Robust CLI interaction with the API, rollback on failure / versioning. - Removal of not supported outputs - Removal of seccomp check - Integration tests - Updated build task to produce containing the user executable beat and the linux beats. - Concurrency / memory settings ## Vendored - aws/aws-lambda-go - aws/aws-sdk-go-v2 --- **Note:** The PR look much bigger because of the vendored files. **Notes 2:** Make sure you add this to your config YAMl, I wan't to make the following the default options but it would have been really messy to do it in this PR. ``` # Disable anything that could be send to disk path.data: /tmp path.logs: /tmp/logs logging.to_stderr: true logging.to_files: false #logging.level: debug setup.template.enabled: true queue.mem: events: 50 flush.min_events: 1 flush.timeout: 0.5s ``` ## related work - #8449 - #8443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project had two licenses, the script was creating two entries in
the NOTICE.txt but both entries would share the same license.
This commit also add the possibility to skip file that start with
LICENSE but doesn't contains any license information.
It also add MIT-0 license wording see https://github.com/aws/mit-0