Cherry-pick #8497 to 6.x: Make logstash module code consistent with other Elastic stack modules #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#8497) This PR makes the Metricbeat `logstash` module code consistent with other Elastic stack modules by: * using `FetchContent()` instead of `FetchJSON()` to fetch data from LS APIs before passing it to the event mapping function. * adding unit tests. Further consistency around event reporting and error handling will be achieved in #8308. (cherry picked from commit 909d789)
houndci-bot
reviewed
Oct 1, 2018
|
|
||
| // +build !integration | ||
|
|
||
| package node_stats |
There was a problem hiding this comment.
don't use an underscore in package name
ruflin
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8497 to 6.x branch. Original message:
This PR makes the Metricbeat
logstashmodule code consistent with other Elastic stack modules by:FetchContent()instead ofFetchJSON()to fetch data from LS APIs before passing it to the event mapping function.Further consistency around event reporting and error handling will be achieved in #8308.