Allow Bus to buffer events in case listeners are not configured #8527
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
libbeat/common/bus/bus.go
Outdated
| @@ -62,6 +63,7 @@ func New(name string) Bus { | |||
| return &bus{ | |||
| name: name, | |||
| listeners: make([]*listener, 0), | |||
| store: make(chan Event, 100), | |||
There was a problem hiding this comment.
this number sounds too arbitrary? I would put it as a parameter
| @@ -65,11 +66,40 @@ func New(name string) Bus { | |||
| } | |||
| } | |||
|
|
|||
| func NewBusWithStore(name string, size int) Bus { | |||
There was a problem hiding this comment.
exported function NewBusWithStore should have comment or be unexported
There was a problem hiding this comment.
lol. does hound not recognize multiline comments? @exekias
There was a problem hiding this comment.
weird, I think it does, let's ignore it this time :)
vjsamuel
force-pushed
the
bus_hold
branch
2 times, most recently
from
842b3ad to
297f6a2
Compare
There was a problem hiding this comment.
LGTM, can you please fix the format issues? https://travis-ci.org/elastic/beats/jobs/436753359
|
jenkins test this please |
This PR allows Beats to store events in a temporary channel in case there is not subscribed listener.
cc: @exekias please see if this is a valid usecase.