Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7871 to 6.4: Recover metrics for old apache versions #8554

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 3, 2018

Cherry-pick of PR #7871 to 6.4 branch. Original message:

Removed by mistake on #6450

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs rebase. Please keep an eye on the Changelog after rebasing.

@sayden
Copy link
Contributor

sayden commented Oct 18, 2018

@jsoriano just FYI Travis complains about Code differs from autopep8's style

@jsoriano
Copy link
Member Author

All travis builds have been failing since a couple of days ago with these errors:

find: `/home/travis/gopath/src/github.com/elastic/beats/build/python-env/bin/autopep8' terminated by signal 13

I think that regarding PEP8 this is fine, indeed it passes on Jenkins.

@sayden
Copy link
Contributor

sayden commented Oct 18, 2018

So yeah, I think you are good to go

@jsoriano jsoriano merged commit 5ba76e0 into elastic:6.4 Oct 18, 2018
@jsoriano jsoriano deleted the backport_7871_6.4 branch October 18, 2018 09:51
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants