Vendor for beatless #8573
Merged
Vendor for beatless #8573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add goformation which is the cloudformation documents. Remove aws/lambda Remove aws/cloudwatchlogs add aws/cloudformation
urso
reviewed
Oct 4, 2018
| "revisionTime": "2017-03-27T23:54:44Z", | ||
| "version": "v1.0.0", | ||
| "versionExact": "v1.0.0" | ||
| }, |
There was a problem hiding this comment.
These are two dependencies of goformation they overrides some behavior on the tags.
https://github.com/awslabs/goformation/blob/master/go.mod#L13-L14
There was a problem hiding this comment.
@urso I wish we didn't have to bring the yaml dependencies, I only use the JSON format :(
Merged
|
CI errors is not related to this PR, but I will do a followup on them. |
urso
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add goformation which is the cloudformation documents.
Remove aws/lambda
Remove aws/cloudwatchlogs
add aws/cloudformation
add go-jmespath
add yaml dependenceis for goformation