Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in color ranges for visualizations #8634

Merged
merged 5 commits into from
Oct 21, 2018
Merged

Fix typo in color ranges for visualizations #8634

merged 5 commits into from
Oct 21, 2018

Conversation

jshvrsn
Copy link
Contributor

@jshvrsn jshvrsn commented Oct 17, 2018 •
edited by exekias
Loading

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sayden sayden added review Metricbeat Metricbeat :Dashboards needs_backport PR is waiting to be backported to other branches. labels Oct 17, 2018
@sayden
Copy link
Contributor

sayden commented Oct 17, 2018

Jenkins test this

@exekias
Copy link
Contributor

exekias commented Oct 18, 2018

Thank you for contributing @jshvrsn, could you please add a changelog entry under CHANGELOG.asciidoc?

@exekias
Copy link
Contributor

exekias commented Oct 18, 2018

Also it would be awesome if you rebase master, as some errors we can see in the CI are fixed there

@exekias
Copy link
Contributor

exekias commented Oct 18, 2018

closes #8633

@ruflin ruflin added the module label Oct 18, 2018
@jshvrsn
Copy link
Contributor Author

jshvrsn commented Oct 18, 2018

@exekias, I rebased on master and added an entry in the changelog. Hopefully I did it properly :) Let me know if you need me to fix anything.

@exekias
Copy link
Contributor

exekias commented Oct 19, 2018

jenkins, test this please

@exekias
Copy link
Contributor

exekias commented Oct 19, 2018

thanks @jshvrsn, it seems the process brought some extra commits but I can handle that on my side 😺

@exekias
Copy link
Contributor

exekias commented Oct 19, 2018

jenkins, test this please

@exekias exekias merged commit 32fad68 into elastic:master Oct 21, 2018
@exekias exekias changed the title Fix typo in color ranges for visualizations #8633 Fix typo in color ranges for visualizations Oct 21, 2018
exekias pushed a commit to exekias/beats that referenced this pull request Oct 21, 2018
@jshvrsn
Fix typo in color ranges for visualizations elastic#8633 (elastic#8634)
5ed2bd3 
* Fix typo preventing color ranges from displaying properly on visualizations.

(cherry picked from commit 32fad68)
@exekias exekias mentioned this pull request Oct 21, 2018
Merged
@exekias exekias added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 21, 2018
exekias added a commit that referenced this pull request Oct 22, 2018
@exekias
Cherry-pick #8634 to 6.x: Fix typo in color ranges for visualizations (…
4057750 
…#8670)

* Fix typo in color ranges for visualizations #8633 (#8634)

* Fix typo preventing color ranges from displaying properly on visualizations.

(cherry picked from commit 32fad68)

* Update CHANGELOG.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
:Dashboards Metricbeat Metricbeat module review v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color ranges broken in Metricbeat visualizations
5 participants
@jshvrsn @elasticmachine @sayden @exekias @ruflin